Skip to content

Commit

Permalink
Update react/Admin.tsx
Browse files Browse the repository at this point in the history 
Co-authored-by: Arthur Bond <arthur.bond@vtex.com.br>
  • Loading branch information
@btalma
btalma and Arthur Bond authored Sep 20, 2023
1 parent 9546372 commit ae5d806
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion react/Admin.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,10 @@ const Admin: FC = () => {

const parsedSettings: any = JSON.parse(data.appSettings.message)

Check warning on line 126 in react/Admin.tsx

View workflow job for this annotation

GitHub Actions / QE / Lint Node.js 

Unexpected any. Specify a different type

setSettingsState(parsedSettings)
setSettingsState({
...settingsState,
...parsedSettings

Check failure on line 130 in react/Admin.tsx

View workflow job for this annotation

GitHub Actions / QE / Lint Node.js 

Insert `,`
})

Check failure on line 131 in react/Admin.tsx

View workflow job for this annotation

GitHub Actions / QE / Lint Node.js 

Delete `··`
}, [data])

Check warning on line 132 in react/Admin.tsx

View workflow job for this annotation

GitHub Actions / QE / Lint Node.js 

React Hook useEffect has a missing dependency: 'settingsState'. Either include it or remove the dependency array. You can also do a functional update 'setSettingsState(s => ...)' if you only need 'settingsState' in the 'setSettingsState' call

if (!data) {
Expand Down

0 comments on commit ae5d806

Please sign in to comment.