Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(acessibility): added aria properties to resolve accessibility is…" #74

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

hellofanny
Copy link
Contributor

Reverts #73

Clients reported that those changes are affecting the eager functionality. It needs to be fixed and is impacting organic SEO due to tracked links by googlebot. We'll need to review this again.

@hellofanny hellofanny requested review from a team as code owners February 28, 2024 14:06
@hellofanny hellofanny requested review from gvc, RodrigoTadeuF and ArthurTriis1 and removed request for a team February 28, 2024 14:06
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 28, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

Fails
🚫

We follow keepachangelog standards.

Please, change the file CHANGELOG.md adding a small summary of your changes under the [Unreleased] section. Example:

 ## [Unreleased]

+ ### Fixed
+ - Issue with image sizing in the SKU Selector.

Possible types of changes:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Generated by 🚫 dangerJS against fce0fa3

@hellofanny hellofanny merged commit 94eee14 into master Feb 28, 2024
4 of 6 checks passed
@hellofanny hellofanny deleted the revert-73-master branch February 28, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants