Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New update function to ga4 ecommerce events #107

Merged

Conversation

natanfernandes
Copy link
Contributor

What is the purpose of this pull request?

Implements the update function working as described on docs and following the line implemented in faststore, isolating the event data and update the event with the correct body

What problem is this solving?

Send the events to window.dataLayer in the correct format

How should this be manually tested?

check if the events in dataLayer are in the correct format {event: ..., ecommerce: { ... } }

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 8, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment for us to discuss first.

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

Copy link
Contributor

@lucasfp13 lucasfp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@natanfernandes natanfernandes merged commit f48f3b2 into feat/settings-merge-ua-events Feb 15, 2023
@natanfernandes natanfernandes deleted the feat/ga4-update-ecommerce branch February 15, 2023 21:17
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 15, 2023

Your PR has been merged! App is being published. 🚀
Version 3.3.1 → 3.4.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.google-tag-manager@3.4.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants