Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the component even if the stock is 0 #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

UnderscoreShift
Copy link

Make this component usable even if the product is out of stock; even the default value is 0. I didn't remove the condition, but replaced 1 with 0 to prevent any issues if bugs occur on the way.

What problem is this solving?

Make this component usable for products out of stock.

How to test it?

N/A

Screenshots or example usage:

N/A

Describe alternatives you've considered, if any.

N/A

Related to / Depends on

N/A

How does this PR make you feel? 🔗

N/A

Make this component usable even if the product is out of stock; even the default value is 0. I didn't remove the condition, but replaced 1 with 0 to prevent any issues if bugs occur on the way.
@UnderscoreShift UnderscoreShift requested a review from a team as a code owner November 9, 2022 11:57
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Nov 9, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@UnderscoreShift UnderscoreShift requested review from danzanzini, eduardoformiga and lucasfp13 and removed request for a team November 9, 2022 11:57
@mihainutiu-vtex
Copy link

Hi @UnderscoreShift
I published a beta version so you can use on the account until this PR is approved and published.

vtex.product-availability@0.3.2-beta.0

Copy link
Author

@UnderscoreShift UnderscoreShift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update CHANGELOG and use abstract operator to make sure null is not returned.

@mihainutiu-vtex
Copy link

Hi @UnderscoreShift
I published a new beta with your latest commit.

vtex.product-availability@0.3.2-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants