Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added variant to facets query #682

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

salesfelipe
Copy link
Contributor

What is the purpose of this pull request?

  • ditto.

Depends on: vtex-apps/store-resources#187

What problem is this solving?

  • Allow A/B testing

How should this be manually tested?

Workspace

Screenshots or example usage

another

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@salesfelipe salesfelipe requested review from a team as code owners October 30, 2024 18:02
@salesfelipe salesfelipe requested review from gabpaladino, RodrigoTadeuF and leo-prange-vtex and removed request for a team October 30, 2024 18:02
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 30, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 30, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@salesfelipe salesfelipe self-assigned this Oct 30, 2024
react/package.json Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@chrsmutti chrsmutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

But there's also an issue that I see recurring regarding breaking SSR when new fields are added to these queries. @hiagolcm has more information on it, I'd wait for his review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants