fix: facets selection #1026
Merged
fix: facets selection #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for faststoreui ready! 🔨 Explore the source changes: fcd21c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/faststoreui/deploys/6195025c7ddb600007252aef 😎 Browse the preview: https://deploy-preview-1026--faststoreui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fcd21c6:
|
emersonlaurentino
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
API had a problem where it only accepted one type of facet being selected. When multiple were selected it chose one.
How it works?
This PR fixes this issue by not merging the facets, but using another algorithm.
How to test it?
Go to base.store and select multiple
sizesin the plp for instance. Compare with both my preview and master. I my preview it should be working as expected.vtex-sites/base.store#113
Before after in the same path:
