feat: basic rating display #2653
Open
+168
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Guilera
force-pushed
the
feat/basic-rating-display
branch
from
f86198c to
1d12420
Compare
lucasfp13
approved these changes
Feb 6, 2025
Comment on lines
+109
to
+113
| const enhancedSku = enhanceSku(sku, product) | ||
|
|
||
| enhancedSku.rating = rating | ||
|
|
||
| return enhancedSku |
There was a problem hiding this comment.
suggestion: Could we pass the rating directly here?
Suggested change
| const enhancedSku = enhanceSku(sku, product) | |
| enhancedSku.rating = rating | |
| return enhancedSku | |
| const enhancedSku = enhanceSku(sku, { ...product, rating }) | |
| return enhancedSku |
| @@ -128,7 +128,7 @@ const ProductCardContent = forwardRef<HTMLElement, ProductCardContentProps>( | |||
| {includeTaxes && ( | |||
| <Label data-fs-product-card-taxes-label>{includeTaxesLabel}</Label> | |||
| )} | |||
| {ratingValue && ( | |||
| {ratingValue != undefined && ( | |||
There was a problem hiding this comment.
suggestion (non-blocking): Since you restricted the value type here, is good to set default value on line 87 (ratingValue = undefined) just to make sure we won't have any different types here (null, for instance)
Guilera
force-pushed
the
feat/basic-rating-display
branch
from
1d12420 to
a561d49
Compare
Guilera
force-pushed
the
feat/basic-rating-display
branch
from
a561d49 to
160d8be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
To add rating stars to existing components:
<ProductCardContent/><ProductTitle/>How it works?
If the feature flag for reviews and ratings, defined at
discovery.config, it's turned on, then everywhere a<ProductCard/>is used then it will display the product star ratingHow to test it?
preview
References
JIRA TASK: SFS-2063
JIRA TASK: SFS-2065
Checklist
You may erase this after checking them all 😉
PR Description
Just ArrivedMost WantedDeals & PromotionsProduct DetailsProduct Gallery