Make chrome debugger be opt-in instead of default #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
To make the chrome debugger tunnel be an explicit opt-in instead of a default open port.
What problem is this solving?
This wastes resources on our cloud if the user is not actively using it. This allows us to intentionally measure the usage of this feature.
How should this be manually tested?
Try linking an app normally and see that it doesn't start the chrome debugger server. By using
--with-debuggerin your linking flow, the previous behavior is restored.Types of changes
Chores checklist
CHANGELOG.md