Add warning on unknown regex escape #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allows adding more details related to literals, coming in the next commits.
Avoid inlining details in the regex Node AST directly.
vthib
force-pushed
the
add-regex-escape-warning
branch
from
d98a4cd to
7d3d699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of VirusTotal/yara#1880 from YARA.
It detects when escaping done in a regex serves no purpose, and emits a warning in that case.
This detection is more strict than the one in YARA, i see no real reason to ignore escaping to '<', '>', '@', '"', etc. Detecting those are more useful than ignoring them.