Improve linux process scan using pagemap #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthib
force-pushed
the
improve-linux-process-scan
branch
3 times, most recently
from
284da2a to
f26ab77
Compare
Unfortunately this brings an additional dependency, but a very common one.
This prevents all sorts of issues in the fetch algorithm. Since those parameters will never sensibly be set anywhere near the page size, this rounding should never be felt by any user. This requires changes in tests because: - one test used a very small value for one of the param - another test changed a param on half a page boundary 4MB is used for the page size, which should always work when running those tests.
The chunking was not correctly applied to the length field, leading to the last chunk failing to read.
The length was not correctly adjusted, although whether that caused bugs is unclear.
vthib
force-pushed
the
improve-linux-process-scan
branch
from
f26ab77 to
2e86db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read memory from the file backing the region if possible, reading from proc mem when the page has been modified by the process.