homepage_url only available in cmake >= 3.12 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMakeLists.txt
Outdated
| @@ -3,8 +3,7 @@ cmake_minimum_required(VERSION 3.5) | |||
| project(cpp-statsd-client | |||
| VERSION 1.0.2 | |||
| LANGUAGES CXX | |||
| DESCRIPTION "A header-only StatsD client implemented in C++" | |||
| HOMEPAGE_URL "https://github.com/vthiery/cpp-statsd-client") | |||
There was a problem hiding this comment.
i think a more appropriate fix might be to change the minimum required version to 3.12.4 on line 2. that way if anyone adds packaging in the future this variable would be the place to get that info. though it is true the url isnt used at the moment
There was a problem hiding this comment.
@kevinkreiser agree. Updated.
kevinkreiser
approved these changes
Nov 23, 2022
kevinkreiser
changed the title
|
Thank you for review/merge @kevinkreiser ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in cmake 3.12.4.