feat: add custom result handler #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @DesselBane, how are you? I really enjoyed this possibility to customize the log, thank you very much for this contribution. Could you add in the documentation (README) this new option and put your use case as an example? |
|
updated the documentation |
|
@DesselBane Done! Now available in v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
Which problems does this PR solve?
If the results of an
axe.run()should be handled in a custom way this is currently not possible.More Context
I'm currently trying to integrate this library with my cypress e2e tests. Now in case of axe validation errors they are outputted to the console but there is no easy way to make the tests fail and output it to the cypress log.
Why use this implementation?
By implementing the
resultHandleras an optional callback nothing of the original functionality is lost which means no breaking change. Also this ways anyone who wants to can handle the results the way he needs to