You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@shrpne
This issue seems caused by lockScroll prop, set lockScroll to false can temporarily fix the drag issue but you will lose the feature of lockScroll when the modal be opened.
lockScroll highly copy paste from body-scroll-lock, I'll need to look into the source code and see if I can fix it. Or re-implement my own version lockScroll with useScrollLock() in @vueuse. However I have no guarantee how much time to fix it.
Also it will be very nice to have it as a dependency from vue-final-modal (maybe explicit install as requirement for modal scroll-locking) for other scroll-locking needs in projects.
@zhaivoronok
Thank you for introducing this library. It looks pretty good to me.
I will consider to replace body-scroll-lock with scroll-lock. If I decide to use scroll-lock. It's going to be a break change for vue-final-modal. It will bump the major version from v4.x to v5.0
Version
vue-final-modal: 4.4.5
vue: 3.3.4
nuxt: 3.6.5
OS
Tested on iOS Safari and on Firefox with enabled touch gestures in devtools
Reproduction Link
https://codesandbox.io/s/frosty-fire-3ztp44
Steps to reproduce
Open modal in iPhone (it should probably be reproduced on any touch device, but I tested only iPhone), try to drag the thumb
What is Expected?
Thumb should slide smoothly on the track
What is actually happening?
Thumb is stuck, sometimes it happens to jump to another position, but it is far from smooth movement
The text was updated successfully, but these errors were encountered: