Skip to content

Conversation

Dschungelabenteuer
Copy link
Contributor

@Dschungelabenteuer Dschungelabenteuer commented Apr 26, 2022

Fixes #173

Exporting a $vfm const within the index.d.ts should be sufficient to correctly import

import { $vfm } from 'vue-final-modal'

which currently emits the following error:

Module '"vue-final-modal"' has no exported member '$vfm'. Did you mean to use 'import $vfm from "vue-final-modal"' instead?

@Dschungelabenteuer Dschungelabenteuer changed the title Exports through the type definition file for typescript imports Exports $vfm through the type definition file for typescript imports Apr 26, 2022
@stonega
Copy link

stonega commented Apr 29, 2022

Hope can be merged soon.

@Mini-ghost Mini-ghost self-requested a review May 1, 2022 05:44
@Mini-ghost Mini-ghost changed the title Exports $vfm through the type definition file for typescript imports fix(type): exports $vfm through the type definition file for typescript imports May 1, 2022
@Mini-ghost Mini-ghost merged commit a1ec314 into vue-final:v3 May 1, 2022
@Mini-ghost
Copy link
Collaborator

Thanks @Dschungelabenteuer 💚

@hunterliu1003
Copy link
Member

hunterliu1003 commented May 6, 2022

Hey @Dschungelabenteuer @stonega
This PR is published at vue-final-modal@3.4.4

@stonega
Copy link

stonega commented May 7, 2022

Thanks! Is it possible to also update v2 version? I am using v2 version with typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants