fix compatibility with choices.js #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where stopping all event propagation in modal container interferes with opening the choices.js modal, which has event listeners on document.
Sandbox with original issue: https://codesandbox.io/s/vue-final-modal-choices-js-issue-5o694?file=/src/components/VModal.vue (choices.js works fine outside the modal, but not inside the modal, where it does not open on click)
My solution: Instead of stopping all event propagation in the modal content, I'm using the .self modifier on the container to only capture direct clicks on it. I stole this from vue-js-modal code. They use a .self.stop modifier, but I'm not sure why the stop would be necessary here.
https://github.com/euvl/vue-js-modal/blob/2682950e4f9ad37b50d0c4bff0a009856df0be9a/src/components/Modal.vue#L15
Please note that I only tested this with a narrow set of configuration options for vue-final-modal as I am not that deep into your code.