Separate bundle and remove deprecated fields #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will correct the merge problem beforehand |
icebob
reviewed
Feb 15, 2017
package.json
Outdated
| @@ -6,7 +6,8 @@ | |||
| "main": "dist/vue-form-generator.js", | |||
| "scripts": { | |||
| "prebuild": "npm run test", | |||
| "build": "webpack --progress --config webpack.build.config.js", | |||
| "build": "webpack --progress --config webpack.build.config.js --define process.env.FULL_BUNDLE=true", | |||
| "buildcore": "webpack --progress --config webpack.build.config.js --define process.env.FULL_BUNDLE=false --output-filename=vue-form-generator-core.js", | |||
| "dev": "webpack-dev-server --config webpack.dev.config.js --inline --hot --content-base dev/", | |||
There was a problem hiding this comment.
Please create 3 build script.
"build:core": "...."
"build:full": "...."
"build": "npm run build:core && npm run build:full"
cristijora
reviewed
Feb 15, 2017
| }); | ||
|
|
||
| if (process.env.FULL_BUNDLE) { // eslint-disable-line | ||
| let Fields = require.context("./fields/optional", false, /^\.\/field([\w-_]+)\.vue$/); |
There was a problem hiding this comment.
Maybe name this optionalFields so it's more clear what it does.
There was a problem hiding this comment.
Yes, I wasn't sure. I will change it too.
There was a problem hiding this comment.
I don't agree with optionalFields, because in the future maybe we will add other stuffs to the full bundle.
|
Sorry, a bit of confusion on my part. I was not seeing the latest commit. |
lionel-bijaoui
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separation into 2 bundles: "core" and "optionnal" #112
removing deprecated fields #120