Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tree组件中,treeNode配置scopedSlots: {title: 'customeTitle' },无法获取title插槽的s… #2006

Merged
merged 2 commits into from
Apr 17, 2020

Conversation

cubemoon
Copy link
Contributor

@cubemoon cubemoon commented Apr 2, 2020

…lot-scope值

需要定制tree的title时,具体的值在treeNode的数据上,但现在无法获取title处的插槽参数。经过查看ant-design-vue源码,发现TreeNode.jsx文件在title处配置错误,希望能尽快修复

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

…lot-scope值

需要定制tree的title时,具体的值在treeNode的数据上,但现在无法获取title处的插槽参数。经过查看ant-design-vue源码,发现TreeNode.jsx文件在title处配置错误,希望能尽快修复
@cubemoon cubemoon changed the title Tree组件中,treeNode配置scopedSlots: {title: 'customeTitle' },无法获取title插槽的s… fix: Tree组件中,treeNode配置scopedSlots: {title: 'customeTitle' },无法获取title插槽的s… Apr 2, 2020
@tangjinzhou
Copy link
Member

没发现有什么问题啊 也没能复现你说的问题,可以提供一个复现示例吗

@cubemoon
Copy link
Contributor Author

cubemoon commented Apr 5, 2020

@tangjinzhou
Copy link
Member

改动不全 你还要需要改这里
https://github.com/vueComponent/ant-design-vue/blob/master/components/tree/Tree.jsx#L170

我先合并这部分了

@tangjinzhou tangjinzhou merged commit 32f669b into vueComponent:master Apr 17, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants