Skip to content

fix: segmentd disabled label is undefined #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2023
Merged

fix: segmentd disabled label is undefined #6556

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16f7632
fix: segmentd disabled label is undefined
selicens May 10, 2023
8f7cb57
fix: segmentd disabled label is undefined
selicens May 10, 2023
993506a
fix: segmentd disabled label is undefined
selicens May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/segmented/src/segmented.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ const SegmentedOption: FunctionalComponent<
payload,
title,
})
: label}
: label
Copy link
Member

@tangjinzhou tangjinzhou May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label ?? value
这样吧，只需要考虑 null 或 undefined 就好了

Copy link
Member Author

@selicens selicens May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以，已修改

? label
: value}
</div>
</label>
);
Expand Down