chore(deps): update dependency webpack-dev-server to v5 [security] #8224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^4.0.0
->^5.0.0
GitHub Vulnerability Alerts
CVE-2025-30359
Summary
Source code may be stolen when you access a malicious web site.
Details
Because the request for classic script by a script tag is not subject to same origin policy, an attacker can inject
<script src="http://localhost:8080/main.js">
in their site and run the script. Note that the attacker has to know the port and the output entrypoint script path. Combined with prototype pollution, the attacker can get a reference to the webpack runtime variables.By using
Function::toString
against the values in__webpack_modules__
, the attacker can get the source code.PoC
npm i
npx webpack-dev-server
https://e29c9a88-a242-4fb4-9e64-b24c9d29b35b.pages.dev/
The script in the POC site is:
This script uses the function generated by
renderRequire
.Especially, it uses the fact that
Array::forEach
is called for__webpack_require__.i
andexecOptions
contains__webpack_require__
.It uses prototype pollution against
Array::forEach
to extract__webpack_require__
reference.Impact
This vulnerability can result in the source code to be stolen for users that uses a predictable port and output path for the entrypoint script.
Old content
Summary
Source code may be stolen when you use
output.iife: false
and access a malicious web site.Details
When
output.iife: false
is set, some global variables for the webpack runtime are declared on thewindow
object (e.g.__webpack_modules__
).Because the request for classic script by a script tag is not subject to same origin policy, an attacker can inject
<script src="http://localhost:8080/main.js">
in their site and run the script. Note that the attacker has to know the port and the output entrypoint script path. By running that, the webpack runtime variables will be declared on thewindow
object.By using
Function::toString
against the values in__webpack_modules__
, the attacker can get the source code.I pointed out
output.iife: false
, but if there are other options that makes the webpack runtime variables to be declared on thewindow
object, the same will apply for those cases.PoC
npm i
npx webpack-dev-server
https://852aafa3-5f83-44da-9fc6-ea116d0e3035.pages.dev/
src/index.js
and other scripts loaded.The script in the POC site is:
Impact
This vulnerability can result in the source code to be stolen for users that has
output.iife: false
option set and uses a predictable port and output path for the entrypoint script.CVE-2025-30360
Summary
Source code may be stolen when you access a malicious web site with non-Chromium based browser.
Details
The
Origin
header is checked to prevent Cross-site WebSocket hijacking from happening which was reported by CVE-2018-14732.But webpack-dev-server always allows IP address
Origin
headers.https://github.com/webpack/webpack-dev-server/blob/55220a800ba4e30dbde2d98785ecf4c80b32f711/lib/Server.js#L3113-L3127
This allows websites that are served on IP addresses to connect WebSocket.
By using the same method described in the article linked from CVE-2018-14732, the attacker get the source code.
related commit: webpack/webpack-dev-server@72efaab (note that
checkHost
function was only used for Host header to prevent DNS rebinding attacks so this change itself is fine.This vulnerability does not affect Chrome 94+ (and other Chromium based browsers) users due to the non-HTTPS private access blocking feature.
PoC
npm i
npx webpack-dev-server
http://{ipaddress}/?target=http://localhost:8080&file=main
with a non-Chromium browser (I used Firefox 134.0.1)src/index.js
in the extracted directorysrc/index.js
The script in the POC site is:
Impact
This vulnerability can result in the source code to be stolen for users that uses a predictable port and uses a non-Chromium based browser.
Release Notes
webpack/webpack-dev-server (webpack-dev-server)
v5.2.2
Compare Source
v5.2.1
Compare Source
Security
Access-Control-Allow-Origin
headerOrigin
header are not allowed to connect to WebSocket server unless configured byallowedHosts
or it different from theHost
headerThe above changes may make the dev server not work if you relied on such behavior, but unfortunately they carry security risks, so they were considered as fixes.
Bug Fixes
v5.2.0
Compare Source
Features
getClientEntry
andgetClientHotEntry
methods to get clients entries (dc642a8)Bug Fixes
v5.1.0
Compare Source
Features
app
option to beFunction
(by default only withconnect
compatibility frameworks) (3096148)server
option to beFunction
(#5275) (02a1c6d)connect
andconnect
compatibility frameworks which support HTTP2 (#5267) (6509a3f)Bug Fixes
platform
property to determinate the target (#5269) (c3b532c)rimraf
withrm
(#5162) (1a1561f)devServer: false
(#5272) (8b341cb)5.0.4 (2024-03-19)
Bug Fixes
5.0.3 (2024-03-12)
Bug Fixes
5.0.2 (2024-02-16)
Bug Fixes
5.0.1 (2024-02-13)
Bug Fixes
require-trusted-types-for
(#5046) (e115436)v5.0.4
Compare Source
v5.0.3
Compare Source
v5.0.2
Compare Source
v5.0.1
Compare Source
v5.0.0
Compare Source
Migration Guide and Changes.
4.15.1 (2023-06-09)
Bug Fixes
::
withlocalhost
before openBrowser() (#4856) (874c44b)@types/ws
(#4899) (34bcec2)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.