bugfix: ignore Enter key triggered by IME #226
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Languages like Japanese or Chinese input characters by something called IME. You may not familiar to this if you only input English characters, but people using IME will have trouble to "Add a new tag" by entering the "Enter" key, because the IME also use Enter key to confirm the user's current input which is different from regular Enter key.
You can use
event.keyCode === 229
to detect if the event is triggered by IME or a regular Enter key.This PR fix the bug by add the above logic to the Enter key handler.
(I have tested the code in my environment, which works great)