Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep comments in babel output(webpack magic comments) #45

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Keep comments in babel output(webpack magic comments) #45

merged 1 commit into from
Jun 28, 2017

Conversation

sudo-suhas
Copy link
Contributor

They are necessary for webpacks "magic comments" to work, e.g. with import(/* webpackChunkName: "chunk1" */ './component.vue')

This PR is a clone of vuejs-templates/webpack#753
Linked Issue - vuejs-templates/webpack#730

addyosmani
addyosmani approved these changes Jun 28, 2017
View reviewed changes
Copy link
Collaborator

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@addyosmani addyosmani merged commit 01151ee into vuejs-templates:master Jun 28, 2017
@sudo-suhas sudo-suhas deleted the keep_comments_in_babel_output branch June 28, 2017 04:40
@sudo-suhas
Copy link
Contributor Author

Do you think it is possible to have a bot which makes clone PR for commits in vuejs-templates/webpack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addyosmani addyosmani addyosmani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudo-suhas @addyosmani