Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make eslint errors in overlay optional #960

Closed
LinusBorg opened this issue Oct 8, 2017 · 1 comment
Closed

Make eslint errors in overlay optional #960

LinusBorg opened this issue Oct 8, 2017 · 1 comment
Assignees
@LinusBorg
Labels
enhancement

Comments

@LinusBorg
Copy link
Contributor

Some people don't want to be disrupted by style errors during development, so stopping HMR and showing eslint errors in the overlay should be optional.
LinusBorg added a commit that referenced this issue Oct 11, 2017
@LinusBorg
close #960
7a6c554
@LinusBorg LinusBorg self-assigned this Oct 11, 2017
@LinusBorg
Copy link
Contributor Author

this will be done with/in #975

LinusBorg added a commit that referenced this issue Nov 8, 2017
@LinusBorg
Switch to webpack-dev-server (close #964) (#975)
aba0f9c 
* Finished testable version.

* close #960

* fix node-notifier version

* remove console.log

* moved general dependency out of unit test-only dependency block.

* fix typo

* ignore /test folder

* make HMR work correctly.

* improve console messages for HMR - now show filenames of replaced modules.

* fix typo in eslint-loader config

* move imports for the env files from /config/index.js directly into the webpack config.

Reasoning: thosen file imports are not configuration, so they don't belong inside of config/index.js

* fix wrong overlay config
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this issue Dec 25, 2017
@LinusBorg @frandiox
Switch to webpack-dev-server (close vuejs-templates#964) (vuejs-templ…
df4913d 
…ates#975)

* Finished testable version.

* close vuejs-templates#960

* fix node-notifier version

* remove console.log

* moved general dependency out of unit test-only dependency block.

* fix typo

* ignore /test folder

* make HMR work correctly.

* improve console messages for HMR - now show filenames of replaced modules.

* fix typo in eslint-loader config

* move imports for the env files from /config/index.js directly into the webpack config.

Reasoning: thosen file imports are not configuration, so they don't belong inside of config/index.js

* fix wrong overlay config
shenron pushed a commit to shenron/webpack that referenced this issue Mar 20, 2018
@LinusBorg
Switch to webpack-dev-server (close vuejs-templates#964) (vuejs-templ…
937dffc 
…ates#975)

* Finished testable version.

* close vuejs-templates#960

* fix node-notifier version

* remove console.log

* moved general dependency out of unit test-only dependency block.

* fix typo

* ignore /test folder

* make HMR work correctly.

* improve console messages for HMR - now show filenames of replaced modules.

* fix typo in eslint-loader config

* move imports for the env files from /config/index.js directly into the webpack config.

Reasoning: thosen file imports are not configuration, so they don't belong inside of config/index.js

* fix wrong overlay config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LinusBorg LinusBorg

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LinusBorg