Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope hoisting in the prod config #1013

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Add scope hoisting in the prod config #1013

merged 1 commit into from
Nov 8, 2017

Conversation

agnivade
Copy link
Contributor

@LinusBorg
Copy link
Contributor

I'm not sure if we can consider this plugin production-ready yet. Last time I checked this was still in the early stages, but admittedly that was some time ago.

@agnivade
Copy link
Contributor Author

Scope hoisting came with webpack 3 which was released in June 19. The template uses 3.6 now. A lot of companies including mine have successfully used scope hoisting now. It was even featured in the Chrome Dev Summit video by @addyosmani.

@LinusBorg LinusBorg added this to the 1.2.0 milestone Nov 1, 2017
@LinusBorg LinusBorg merged commit f1d323b into vuejs-templates:develop Nov 8, 2017
@kuoruan
Copy link

kuoruan commented Nov 9, 2017

@agnivade Enable this gives me a Error

Uncaught TypeError: Cannot read property 'call' of undefined
    at r (manifest.3fe6de900fd915a3ce9a.js:1)
    at Object.NHnr (app.3cf392e250a975da6f37.js:1)
    at r (manifest.3fe6de900fd915a3ce9a.js:1)
    at window.webpackJsonp (manifest.3fe6de900fd915a3ce9a.js:1)
    at app.3cf392e250a975da6f37.js:1

My webpack version is 3.8.1

@agnivade
Copy link
Contributor Author

agnivade commented Nov 9, 2017

Well, I guess you should raise an issue in the webpack repo. I just sent this PR because I applied this and noticed good improvements. I am no way an expert in Webpack.

@kuoruan
Copy link

kuoruan commented Nov 10, 2017

@agnivade OK, thank you. I find the same issue at webpack/webpack#959 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants