Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: set karma as default #1073

Closed
wants to merge 2 commits into from
Closed

refactor: set karma as default #1073

wants to merge 2 commits into from

Conversation

eddyerburgh
Copy link
Contributor

@LinusBorg
Copy link
Contributor

See #1074 - I think we get Jest running on windows after all :)

LinusBorg
LinusBorg suggested changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to merge this if #1074 approach isn't successful.

@robertmain
Copy link

robertmain commented Nov 16, 2017 •
edited
Loading

FYI: Jest is the only thing that I can get to actually run my tests(albeit not in it's current configuration)

@LinusBorg
Copy link
Contributor

It seems the new setup will work, I'll close this for now. We can still revert if we come across other problems.

@LinusBorg LinusBorg closed this Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddyerburgh @LinusBorg @robertmain