Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert #996, #997 chunk names to minify prodution JS #1086

Merged
merged 1 commit into from
Nov 20, 2017
Merged

revert #996, #997 chunk names to minify prodution JS #1086

merged 1 commit into from
Nov 20, 2017

Conversation

c0defre4k
Copy link
Contributor

As mentioned in #996 and #997 this reverts using name instead of id to generate smaller production javascript files.

@c0defre4k c0defre4k changed the title revert #996 chunk names to minify prodution JS revert #996, #997 chunk names to minify prodution JS Nov 20, 2017
Copy link
Contributor

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert is better indeed.

@LinusBorg LinusBorg merged commit d232576 into vuejs-templates:develop Nov 20, 2017
LinusBorg added a commit that referenced this pull request Nov 21, 2017
* develop:
  bump v1.2.4
  revert #996 chunk names to minify prodution JS (#1086)
  fix missing comma
  Batman!
  add missing cacheBusting option
  make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern
  Improved Jest config (#1074)
  Fix # 1070 When index.html has a positional variable, the error can be printed correctly (#1071)
  [enhancement]Remove useless files and performance enhancement in dev server. (#1072)
c0defre4k pushed a commit to neonblack-at/webpack that referenced this pull request Nov 30, 2017
* vuejs-templates/master:
  bump v1.2.4
  Simplify elementCount custom assertions (vuejs-templates#898)
  revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086)
  fix missing comma
  Batman!
  add missing cacheBusting option
  make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern
  Improved Jest config (vuejs-templates#1074)
  Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071)
  [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
* develop:
  bump v1.2.4
  revert vuejs-templates#996 chunk names to minify prodution JS (vuejs-templates#1086)
  fix missing comma
  Batman!
  add missing cacheBusting option
  make jest ignore the e2e test folder because its likely to contain files matching the jest's filename pattern
  Improved Jest config (vuejs-templates#1074)
  Fix # 1070 When index.html has a positional variable, the error can be printed correctly (vuejs-templates#1071)
  [enhancement]Remove useless files and performance enhancement in dev server. (vuejs-templates#1072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants