Skip to content

Add more integration tests (expect scripts) #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Toilal
Copy link
Contributor

@Toilal Toilal commented Dec 12, 2017

This adds more integration tests with expect scripts and some bash scripts.

I run this kind of tests on my fork since months and it does the job. I'm using TravisCI on my fork, but it should work with CircleCI too.

This check for many answers series (defined in expect scripts) if generation, lint, tests and build returns 0 exit code.

@Toilal
Copy link
Contributor Author

Toilal commented Dec 12, 2017

For some reason, those tests fails when using the brand new automated "npm install", so expect script are written to answer "No" to the last question, and bash script runs the commands manually.

@Toilal Toilal force-pushed the integration-tests branch 4 times, most recently from 788b0cc to 17d825a Compare December 13, 2017 10:51
@LinusBorg
Copy link
Contributor

Hey,

I have been working on improving the CI tests for some time, and took a very different approach - one that doesn't rely on bash so windows users can run them too.

Please have a look at #1218

@Toilal Toilal closed this Jan 15, 2018
@Toilal Toilal deleted the integration-tests branch January 15, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants