Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping up a few versions #658

Merged
merged 3 commits into from
Apr 19, 2017
Merged

Conversation

DanielPe05
Copy link
Contributor

This will update a few versions, one of them allowing us to get rid of that warning that's been bothering a few people (myself included) so much.

(node:33278) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.

This will update a few versions, one of them allowing us to get rid of that warning that's been bothering a few people (myself included) so much.
```(node:33278) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.```
Copy link
Contributor

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test all of this?

Most bumps seem fine, but we stayed on inject-loader 2.* because 3.* didn't work correctly with vue files.

So we can't bump that dependency unless we can be sure it works now.

@DanielPe05
Copy link
Contributor Author

@LinusBorg I have been testing it. I'm using both .vue and .js component files and it seems to be just fine. I will keep testing, but so far so good.

@DanielPe05
Copy link
Contributor Author

@LinusBorg I'm deploying this to production on my project as it all seems to be working just fine locally. I will let you know if hell breaks loose once it gets there. But hopefully it all goes smoothly. Take it for a spin if you wish.

@LinusBorg
Copy link
Contributor

Ok I think we can merge this, looked fine in my test as well.

@LinusBorg LinusBorg merged commit 2e7aad5 into vuejs-templates:master Apr 19, 2017
@DanielPe05 DanielPe05 deleted the patch-2 branch February 20, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants