Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for linked modules #688

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Add support for linked modules #688

merged 1 commit into from
Aug 28, 2017

Conversation

adambiggs
Copy link
Contributor

After this change I was able to develop with locally-linked packages using $ yarn link/$ npm link.

@LinusBorg LinusBorg merged commit 7c1e230 into vuejs-templates:master Aug 28, 2017
LinusBorg added a commit that referenced this pull request Aug 29, 2017
@LinusBorg
Revert #688, fix #879
0866970 
We have to investigate how we can get #688 work without the error reported in #879
JasonGrubb pushed a commit to JasonGrubb/webpack that referenced this pull request Aug 30, 2017
@rwb7041 @JasonGrubb
Beltrw mods (#9)
f1b859d 
* babel should keep code comments. (fix vuejs-templates#730) (vuejs-templates#753)

They are necessary for webpacks "magic comments" to work, e.g. with `import(/* webpackChunkName: "chunk1" */ './component.vue')`

* build: Configure targets.browser for babel-preset-env (vuejs-templates#763)

* Remove inconsistent spacing (vuejs-templates#754)

* feat(gitignore): include common editor directories (vuejs-templates#774)

* feat(gitignore): include common editor directories

add common editor files and directories to .gitignore

closes vuejs-templates#772

* feat(gitignore): remove .vscode directory

remove .vscode directory from .gitignore

* Video audio loader (vuejs-templates#765)

* gitignore vscode

* media loader

audio and video tag

* Remove vscode gitignore

* Add \n back

* fix missing closing bracket

* add default values (img, image)

* Upgrade vue-router to v2.6.0 (vuejs-templates#777)

* Fix console error (vuejs-templates#784)

Fix console error`Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING`

* Fix proxy example (fix vuejs-templates#780)

the glob pattern was too narrow, woudl not catch subpaths.

* Fix autoprefixer explanation (vuejs-templates#798)

The parameter to set in package.json is named "browserslist".

* chore: Bump dev dependencies for template (vuejs-templates#790)

* fix: Use false to disable webpack-hot-middleware log (vuejs-templates#778)

* Move Chat: Gitter -> Discord (vuejs-templates#869)

* Remove unnecessary space and comma (vuejs-templates#866)

* load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864)

* Return exit code 1 when npm run build fails (vuejs-templates#854)

* fix standard eslint config link (vuejs-templates#834)

* fix ci build faild (vuejs-templates#857)

* Removing Vue.config.debug usage from documentation (vuejs-templates#871)

* Removing Vue.config.debug usage from documentation

It has been removed; https://vuejs.org/v2/guide/migration.html#Vue-config-debug-removed

* Update env.md

* fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876)

* bump vue & vue-router dependencies

* Specify the address to listen on (vuejs-templates#759)

Currently, this causes the dev server to listen on all addresses by default, which is not the intended behavior, imo.

* add HashedModuleIdsPlugin when build (vuejs-templates#870)

* Add support for linked modules (vuejs-templates#688)

* chore(package): rm unused lolex dependency(dev) (vuejs-templates#803)

* fix vuejs-templates#877

* Revert vuejs-templates#688, fix vuejs-templates#879

We have to investigate how we can get vuejs-templates#688 work without the error reported in vuejs-templates#879

* revert: vuejs-templates#759

That's actually not a good idea when you e.g. want to access the dev server from your mobile.

* - Re-added check for router
- Modified eslint file to use standard and have M be a global
rwb7041 added a commit to JasonGrubb/webpack that referenced this pull request Aug 31, 2017
@rwb7041 @JasonGrubb
Merged in beltrw_mods (pull request #1)
0ed883f 
Beltrw mods

* babel should keep code comments. (fix vuejs-templates#730) (vuejs-templates#753)

    They are necessary for webpacks "magic comments" to work, e.g. with `import(/* webpackChunkName: "chunk1" */ './component.vue')`

* build: Configure targets.browser for babel-preset-env (vuejs-templates#763)

* Remove inconsistent spacing (vuejs-templates#754)

* feat(gitignore): include common editor directories (vuejs-templates#774)

    * feat(gitignore): include common editor directories

    add common editor files and directories to .gitignore

    closes vuejs-templates#772

    * feat(gitignore): remove .vscode directory

    remove .vscode directory from .gitignore

* Video audio loader (vuejs-templates#765)

    * gitignore vscode

    * media loader

    audio and video tag

    * Remove vscode gitignore

    * Add \n back

    * fix missing closing bracket

    * add default values (img, image)

* Upgrade vue-router to v2.6.0 (vuejs-templates#777)

* Fix console error (vuejs-templates#784)

    Fix console error`Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING`

* Fix proxy example (fix vuejs-templates#780)

    the glob pattern was too narrow, woudl not catch subpaths.

* Fix autoprefixer explanation (vuejs-templates#798)

    The parameter to set in package.json is named "browserslist".

* chore: Bump dev dependencies for template (vuejs-templates#790)

* fix: Use false to disable webpack-hot-middleware log (vuejs-templates#778)

* Move Chat: Gitter -> Discord (vuejs-templates#869)

* Remove unnecessary space and comma (vuejs-templates#866)

* load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864)

* Return exit code 1 when npm run build fails (vuejs-templates#854)

* fix standard eslint config link (vuejs-templates#834)

* fix ci build faild (vuejs-templates#857)

* Removing Vue.config.debug usage from documentation (vuejs-templates#871)

    * Removing Vue.config.debug usage from documentation

    It has been removed; https://vuejs.org/v2/guide/migration.html#Vue-config-debug-removed

    * Update env.md

* fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876)

* bump vue & vue-router dependencies

* Specify the address to listen on (vuejs-templates#759)

    Currently, this causes the dev server to listen on all addresses by default, which is not the intended behavior, imo.

* add HashedModuleIdsPlugin when build (vuejs-templates#870)

* Add support for linked modules (vuejs-templates#688)

* chore(package): rm unused lolex dependency(dev) (vuejs-templates#803)

* fix vuejs-templates#877

* Revert vuejs-templates#688, fix vuejs-templates#879

    We have to investigate how we can get vuejs-templates#688 work without the error reported in vuejs-templates#879

* revert: vuejs-templates#759

    That's actually not a good idea when you e.g. want to access the dev server from your mobile.

* - Re-added check for router
    - Modified eslint file to use standard and have M be a global

Approved-by: Jason Grubb <grubbjt@appstate.edu>
@airyland
Copy link

airyland commented Sep 5, 2017

I wonder why not use default value true or remain unchanged as people can just edit the config? Now with value:false I have to add a tip in my components document for how to import VUX with webpack template: setting symlinks to true first.

You may know cnpm is the largest npm mirror in China, after using cnpm install, every npm module will be a symlink. And for VUX components, I need to add babel-loader for node_modules/vux/src/**/*.js, but loader will not work if symlink is set to false.

npm run build will get:
image

@LinusBorg
Copy link
Contributor

LinusBorg commented Sep 5, 2017 •
edited
Loading

I wonder why not use default value true or remain unchanged as people can just edit the config? Now with value:false

What value are you talking about? where do you set this?

Edit: Oh, you mean this? No idea why that's set to false, actually (wasn't added by me).

Please open a new issue so we can track this while I try to clarify with the other why this was set and if we can change it.

@airyland
Copy link

airyland commented Sep 5, 2017 •
edited
Loading

@LinusBorg

yes, symlinks: false

https://github.com/LightmakerCanada/webpack/blob/bc864770a6e8361b509f517e4a88f7fc040d8a0f/template/build/webpack.base.conf.js#L30

@maxmilton
Copy link

@airyland that line is already removed in master.

@airyland
Copy link

airyland commented Sep 5, 2017

@maxmilton

I can still see that line:
https://github.com/vuejs-templates/webpack/blob/master/template/build/webpack.base.conf.js#L30

@maxmilton
Copy link

Sorry, you're right! I was looking at the wrong repo 😓

@LinusBorg
Copy link
Contributor

Will revert his. I already tried to revert this PR, but failed to remove the symlinks line. Just gimme a sec.

LinusBorg added a commit that referenced this pull request Sep 5, 2017
@LinusBorg
cleanup some leftover from reverting #688
fb39683
LinusBorg added a commit that referenced this pull request Sep 5, 2017
@LinusBorg
Merge some small fixes (#900)
313c5ad 
* Remove unused fs require from webpack.base.conf.js (#893)

* cleanup some leftover from reverting #688
c0defre4k pushed a commit to neonblack-at/webpack that referenced this pull request Sep 13, 2017
Merge remote-tracking branch 'vuejs-templates/master'
62e7e60 
* vuejs-templates/master:
  Merge some small fixes (vuejs-templates#900)
  Update vue-loader link (vuejs-templates#886)
  match vue-template-compiler version
  revert: vuejs-templates#759
  Revert vuejs-templates#688, fix vuejs-templates#879
  fix vuejs-templates#877
  chore(package): rm unused lolex dependency(dev) (vuejs-templates#803)
  Add support for linked modules (vuejs-templates#688)
  add HashedModuleIdsPlugin when build (vuejs-templates#870)
  Specify the address to listen on (vuejs-templates#759)
  bump vue & vue-router dependencies
  fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876)
  Removing Vue.config.debug usage from documentation (vuejs-templates#871)
  fix ci build faild (vuejs-templates#857)
  fix standard eslint config link (vuejs-templates#834)
  Return exit code 1 when npm run build fails (vuejs-templates#854)
  load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864)
  Remove unnecessary space and comma (vuejs-templates#866)
  Move Chat: Gitter -> Discord (vuejs-templates#869)

# Conflicts:
#	template/package.json
LinusBorg pushed a commit that referenced this pull request Sep 30, 2017
@gucong3000 @LinusBorg
update URL of ESLint to https (#927)
8ac9bb9 
* Update vue-loader link (#886)

* Merge some small fixes (#900)

* Remove unused fs require from webpack.base.conf.js (#893)

* cleanup some leftover from reverting #688

* update URL of ESLint to https

* fix missing comma from conflict resolution
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this pull request Oct 13, 2017
@gucong3000 @frandiox
update URL of ESLint to https (vuejs-templates#927)
2c1947a 
* Update vue-loader link (vuejs-templates#886)

* Merge some small fixes (vuejs-templates#900)

* Remove unused fs require from webpack.base.conf.js (vuejs-templates#893)

* cleanup some leftover from reverting vuejs-templates#688

* update URL of ESLint to https

* fix missing comma from conflict resolution
LinusBorg pushed a commit that referenced this pull request Nov 8, 2017
@LinusBorg
fix postcss config (#890)
583b6bb 
* Update vue-loader link (#886)

* Merge some small fixes (#900)

* Remove unused fs require from webpack.base.conf.js (#893)

* cleanup some leftover from reverting #688

* fix postcss config

* userPostCSS config
frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this pull request Dec 25, 2017
@frandiox
fix postcss config (vuejs-templates#890)
feb45a0 
* Update vue-loader link (vuejs-templates#886)

* Merge some small fixes (vuejs-templates#900)

* Remove unused fs require from webpack.base.conf.js (vuejs-templates#893)

* cleanup some leftover from reverting vuejs-templates#688

* fix postcss config

* userPostCSS config
shenron pushed a commit to shenron/webpack that referenced this pull request Mar 20, 2018
@LinusBorg
fix postcss config (vuejs-templates#890)
82aa0d4 
* Update vue-loader link (vuejs-templates#886)

* Merge some small fixes (vuejs-templates#900)

* Remove unused fs require from webpack.base.conf.js (vuejs-templates#893)

* cleanup some leftover from reverting vuejs-templates#688

* fix postcss config

* userPostCSS config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adambiggs @airyland @LinusBorg @maxmilton