Ignore files improvements #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @exarus Will look into this and probably merge for the next version, this looks like a great and long-needed cleanup! Thanks! |
yugasun
pushed a commit
to yugasun/webpack
that referenced
this pull request
Nov 2, 2017
* .eslintignore covers paths that contain generated *.js files * .gitignore doesn't ignore unnecassary paths * root .js files are added to ESLint ignore list
frandiox
pushed a commit
to OnsenUI/vue-cordova-webpack
that referenced
this pull request
Nov 22, 2017
* .eslintignore covers paths that contain generated *.js files * .gitignore doesn't ignore unnecassary paths * root .js files are added to ESLint ignore list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.eslintignoreAs I understand the file is included for users that use the globally installed
eslint. Hense I usedeslint --ext .js,.vueto check the correctness of.eslintignore..eslintignorebeforeWhat is changed:
*.jssuffixes removed because they are not necessary to ignore the wholebuildandconfigdirectories/prefix is omitted than anyconfigorbuilddirectories in the repository will be ignored (i.e.src/config/myConfig.jswill not be linted). This PR adds the/prefix.*.jsconfig files from root directory are ignored by ESLint (currently they will fail linting process forairbnbstyle because of;absence)/test/unit/coverage/folder. They will be ignored after PR merge./dist/will be ignored after PR merge..gitignore/to several paths (i.e./dist/). So after this PR users will be able to addsrc/dist/normalDistribution.jstogitrepository./prefix tonode_modules/because any nestednode_modulesfolders are usually have relatedpackage.jsonand thus are not intended to be committed to source control.Used resources
Any feedback is welcome.