-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to webpack-dev-server (close #964) #975
Changes from 3 commits
3183cd5
7a6c554
dfbc195
6800a9d
fb89911
e0e884f
9891c86
afe56e6
302e841
11122cb
505446d
6d943ac
430406e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,18 +6,31 @@ const merge = require('webpack-merge') | |
const baseWebpackConfig = require('./webpack.base.conf') | ||
const HtmlWebpackPlugin = require('html-webpack-plugin') | ||
const FriendlyErrorsPlugin = require('friendly-errors-webpack-plugin') | ||
const portfinder = require('portfinder') | ||
|
||
// add hot-reload related code to entry chunks | ||
Object.keys(baseWebpackConfig.entry).forEach(function (name) { | ||
baseWebpackConfig.entry[name] = ['./build/dev-client'].concat(baseWebpackConfig.entry[name]) | ||
}) | ||
|
||
module.exports = merge(baseWebpackConfig, { | ||
const devWebpackConfig = merge(baseWebpackConfig, { | ||
module: { | ||
rules: utils.styleLoaders({ sourceMap: config.dev.cssSourceMap }) | ||
}, | ||
// cheap-module-eval-source-map is faster for development | ||
devtool: '#cheap-module-eval-source-map', | ||
|
||
// these devServer options should be customized in /config/index.js | ||
devServer: { | ||
host: process.env.HOST || config.dev.host, | ||
port: process.env.PORT || config.dev.port, | ||
open: config.dev.autoOpenBrowser, | ||
overlay: config.dev.errorOverlay ? { | ||
warnings: true, | ||
errors: true, | ||
} : false, | ||
publicPath: config.dev.assetsPublicPath, | ||
proxy: config.dev.proxyTable, | ||
quiet: true, // necessary for FriendlyErrorsPlugin | ||
watchOptions: { | ||
poll: config.dev.poll, | ||
} | ||
}, | ||
plugins: [ | ||
new webpack.DefinePlugin({ | ||
'process.env': config.dev.env | ||
|
@@ -34,3 +47,29 @@ module.exports = merge(baseWebpackConfig, { | |
new FriendlyErrorsPlugin() | ||
] | ||
}) | ||
|
||
module.exports = new Promise((resolve, reject) => { | ||
portfinder.basePort = process.env.PORT || config.dev.port | ||
portfinder.getPort((err, port) => { | ||
if (err) { | ||
reject(err) | ||
} else { | ||
// publish the new Port, necessary for e2e tests | ||
process.env.PORT = port | ||
// add port to devServer config | ||
devWebpackConfig.devServer.port = port | ||
|
||
// Add FriendlyErrorsPlugin | ||
devWebpackConfig.plugins.push(new FriendlyErrorsPlugin({ | ||
compilationSuccessInfo: { | ||
messages: [`You application is running here http://${config.dev.host}:${port}`], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/You/Your/ |
||
}, | ||
onErrors: config.dev.notifyOnErrors | ||
? utils.createNotifierCallback() | ||
: undefined | ||
})) | ||
|
||
resolve(devWebpackConfig) | ||
} | ||
}) | ||
}) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
"author": "{{ author }}", | ||
"private": true, | ||
"scripts": { | ||
"dev": "node build/dev-server.js", | ||
"dev": "webpack-dev-server --inline --hot --progress --config build/webpack.dev.conf.js", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to remove line 38 and 39 from // https://github.com/glenjamin/webpack-hot-middleware#installation--usage
new webpack.HotModuleReplacementPlugin(), The |
||
"start": "npm run dev", | ||
"build": "node build/build.js"{{#unit}}, | ||
"unit": "cross-env BABEL_ENV=test karma start test/unit/karma.conf.js --single-run"{{/unit}}{{#e2e}}, | ||
|
@@ -29,7 +29,6 @@ | |
"babel-preset-stage-2": "^6.22.0", | ||
"babel-register": "^6.22.0", | ||
"chalk": "^2.0.1", | ||
"connect-history-api-fallback": "^1.3.0", | ||
"copy-webpack-plugin": "^4.0.1", | ||
"css-loader": "^0.28.0", | ||
{{#lint}} | ||
|
@@ -51,12 +50,10 @@ | |
{{/if_eq}} | ||
{{/lint}} | ||
"eventsource-polyfill": "^0.9.6", | ||
"express": "^4.14.1", | ||
"extract-text-webpack-plugin": "^3.0.0", | ||
"file-loader": "^1.1.4", | ||
"friendly-errors-webpack-plugin": "^1.6.1", | ||
"html-webpack-plugin": "^2.30.1", | ||
"http-proxy-middleware": "^0.17.3", | ||
"webpack-bundle-analyzer": "^2.9.0", | ||
{{#unit}} | ||
"cross-env": "^5.0.1", | ||
|
@@ -70,6 +67,7 @@ | |
"karma-spec-reporter": "0.0.31", | ||
"karma-webpack": "^2.0.2", | ||
"mocha": "^3.2.0", | ||
"node-notifier": "^5.1.2", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should move this line outside of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, right. thanks! |
||
"chai": "^4.1.2", | ||
"sinon": "^4.0.0", | ||
"sinon-chai": "^2.8.0", | ||
|
@@ -85,7 +83,6 @@ | |
{{/e2e}} | ||
"semver": "^5.3.0", | ||
"shelljs": "^0.7.6", | ||
"opn": "^5.1.0", | ||
"optimize-css-assets-webpack-plugin": "^3.2.0", | ||
"ora": "^1.2.0", | ||
"rimraf": "^2.6.0", | ||
|
@@ -95,8 +92,7 @@ | |
"vue-template-compiler": "^2.4.2", | ||
"portfinder": "^1.0.13", | ||
"webpack": "^3.6.0", | ||
"webpack-dev-middleware": "^1.12.0", | ||
"webpack-hot-middleware": "^2.18.2", | ||
"webpack-dev-server": "^2.9.1", | ||
"webpack-merge": "^4.1.0" | ||
}, | ||
"engines": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to remove this log 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops!