-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allowBlank option #51
base: master
Are you sure you want to change the base?
Conversation
Adds a new option that, when set to true, allows v-money fields to be initialized blank or cleared out by the user. The option is false by default, so it should not impact existing v-money fields. Addresses vuejs-tips#28
This is a must!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I've made a fork with similar changes but this approach is cleaner and way better to mantain since it's backward compatible.
Thanks, @gfviegas! I'm referencing my fork at https://github.com/nholden/v-money in a project right now, but it would be great to see this or something similar included in a future release. |
Please accept this PR |
2 similar comments
Please accept this PR |
Please accept this PR |
Looks like this was added way back in February, but still no merge :( Is there a way to pull your version in through NPM, so I can use it, instead...? |
I'm using Yarn, so I ran the following to add my fork to a project.
Looks like that would also work for NPM, although I haven't tried it.
|
@nholden Ah dang, I didn't notice your implementation is only on the directive. Any plans to add it to the component version, as well? |
@DinsmoreDesign Seems like it wouldn't be too tricky. Let me take a closer look this evening and get back to you. |
@DinsmoreDesign I just updated this PR as well as my fork to add the |
@nholden Awesome! I was going to tinker with it and submit a pull request to your pull request, but that seemed like a lot of pull requests :P |
Really would like this pr merged 😄 |
Please accept this PR |
Hey, everybody! Thanks for sharing that this PR is still relevant for you. To reduce the noise for everyone subscribed to this PR: if you'd like to voice your support for this moving forward, please give a 👍 to the original post. If you need this functionality now, please see this comment on how to use my fork. And, of course, if you have other feedback, feel free to comment. Thanks! |
@neves can we get this please? |
Please accept this PR |
There's a bug. Input can be blank but it uses |
Any update about this PR? |
@marcusmouraoca: This is unlikely to be merged, and I'm not going to make any additional changes. If you need this functionality now, please see this comment on how to use my fork, or you can fork it yourself. |
better late than never hell yeah |
Adds a new option that, when set to true, allows v-money fields to be initialized blank or cleared out by the user. The option is false by default, so it should not impact existing v-money fields.
Addresses #28