Skip to content

Omit children if possible #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2017
Merged

Omit children if possible #92

merged 1 commit into from
Nov 6, 2017

Conversation

whtsky
Copy link
Contributor

@whtsky whtsky commented Aug 15, 2017

fix #90

@nickmessing
Copy link
Member

nickmessing commented Aug 15, 2017 •
edited
Loading

@whtsky, LGTM there still is this scenario:

<tag domPropsInnerHTML="test">Hello</tag>

but I think we don't need to consider that.

@nickmessing nickmessing requested a review from yyx990803 August 15, 2017 11:13
@whtsky
Copy link
Contributor Author

whtsky commented Aug 15, 2017

emm.. it's kinda weird but <div domPropsInnerHTML="test">Hello</div> works pretty well under SSR.

@whtsky whtsky changed the title omit children if possible Omit children if possible Aug 17, 2017
@nickmessing
Copy link
Member

@whtsky, that doesn't solve the problem, check last comment on #90

@nickmessing nickmessing closed this Sep 5, 2017
@whtsky whtsky mentioned this pull request Nov 6, 2017
Closed
@yyx990803 yyx990803 reopened this Nov 6, 2017
@yyx990803 yyx990803 merged commit e5dcbb6 into vuejs:master Nov 6, 2017
@LinusBorg LinusBorg mentioned this pull request Jan 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

domPropsInnerHTML incorrect markup
3 participants
@whtsky @nickmessing @yyx990803