Skip to content

replace node-sass to dart-sass #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2019
Merged

replace node-sass to dart-sass #56

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea41bb
replace node-sass to sass
Mar 20, 2019
41f857f
Merge branch 'master' into change_dart_sass
znck Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/styleProcessors/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const scss: StylePreprocessor = {
map: any | null,
options: any
): StylePreprocessorResults {
const nodeSass = require('node-sass')
const nodeSass = require('sass')
const finalOptions = Object.assign({}, options, {
data: source,
file: options.filename,
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@
"jest": "^24.0.0",
"less": "^3.9.0",
"lint-staged": "^8.1.1",
"node-sass": "^4.11.0",
"pug": "^2.0.3",
"sass": "^1.17.3",
"stylus": "^0.54.5",
"ts-jest": "^24.0.0",
"typescript": "^3.3.0",
Expand Down
2 changes: 1 addition & 1 deletion test/compileStyle.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ test('preprocess sass', () => {
const style = parse({
source:
'<style lang="sass">\n' +
'$red: rgb(255, 0, 0);\n' +
'$red: rgb(255, 0, 0)\n' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a breaking change IMO. Though dart-sass & node-sass are both compliant with the sass spec, there're many subtle differences underlyingly, especially when it comes to error tolerance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth the breaking change for not be needing to compile node-sass?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't affect vue-loader but rollup-plugin-vue would need a major bump /cc @znck

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be a major bump for compiler utils as well as RPV.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, let's leave it up to you to decide when to merge this PR and release a new major for both libraries 👀

'.color\n' +
' color: $red\n' +
'</style>\n',
Expand Down
Loading