Skip to content

fix(watch): component should runCleanup() on unmount #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LinusBorg merged 2 commits into from
Apr 24, 2020
Merged

fix(watch): component should runCleanup() on unmount #298

LinusBorg merged 2 commits into from
Apr 24, 2020

Conversation

@LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Mar 30, 2020 •
edited
Loading

  • watchEffect now properly calls runCleanup() when the component unmounts.
  • I applied the same change for "normal" watchers as I found that the bug applied to those as well.

Would like a second pair of eyes though, to verify.

close #293

@LinusBorg LinusBorg changed the title fix(watch): component should runCleaup() on unmount fix(watch): component should runCleanup() on unmount Mar 30, 2020
@LinusBorg LinusBorg force-pushed the fix-293-watch_cleanup-on-unmount branch from 434cd8c to 8297872 Compare March 30, 2020 17:49
pikax
pikax reviewed Apr 24, 2020
View reviewed changes
@LinusBorg LinusBorg self-assigned this Apr 24, 2020
@LinusBorg LinusBorg merged commit d1715e4 into master Apr 24, 2020
@LinusBorg LinusBorg deleted the fix-293-watch_cleanup-on-unmount branch April 24, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pikax pikax pikax approved these changes

Assignees

@LinusBorg LinusBorg

Labels

PR:Bugfix PR:Review-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WatchEffect's onCleanup is not firing when component is unmounted

3 participants

@LinusBorg @pikax