-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve conflicts with vue2 interface #869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MinatoHikari Can you add some type test for this in directory |
One problem, type checking in vsCode or webStorm is fine but vue-tsc will be failed when using vue3 tsconfig. Because $emit in vue3's mounted instance dosen't return itself., so something like |
@MinatoHikari Maybe we can remove vue-class-component and vue-property-decorator in devDependencies. Only extract simpler use case from it. |
…when use vue3 type
Remove vue-class-component and vue-property-decorator. |
#850
Vue2 renderComponent Interface is different from vue3 now.
It works for me to resolve type error when I use Mixins in vue-class-component
Maybe we can change it's type again after vue2.7