Merge branch 'main' into issue-10236

.github/renovate.json5

@@ -46,5 +46,9 @@
 
  // ESM only
  'estree-walker',
+
+ // pinned
+ // https://github.com/vuejs/core/issues/10300#issuecomment-1940855364
+ 'lru-cache',
  ],
 }

.github/workflows/ci.yml

@@ -65,7 +65,7 @@ jobs:
  - uses: actions/checkout@v4
 
  - name: Setup cache for Chromium binary
- uses: actions/cache@v3
+ uses: actions/cache@v4
  with:
  path: ~/.cache/puppeteer
  key: chromium-${{ hashFiles('pnpm-lock.yaml') }}

.github/workflows/size-data.yml

@@ -36,7 +36,7 @@ jobs:
  - run: pnpm run size
 
  - name: Upload Size Data
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
  with:
  name: size-data
  path: temp/size
@@ -45,7 +45,7 @@ jobs:
  if: ${{github.event_name == 'pull_request'}}
  run: echo ${{ github.event.number }} > ./pr.txt
 
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
  if: ${{github.event_name == 'pull_request'}}
  with:
  name: pr-number

.github/workflows/size-report.yml

@@ -36,7 +36,7 @@ jobs:
  run: pnpm install
 
  - name: Download PR number
- uses: dawidd6/action-download-artifact@v2
+ uses: dawidd6/action-download-artifact@v3
  with:
  name: pr-number
  run_id: ${{ github.event.workflow_run.id }}
@@ -48,14 +48,14 @@ jobs:
  path: ./pr.txt
 
  - name: Download Size Data
- uses: dawidd6/action-download-artifact@v2
+ uses: dawidd6/action-download-artifact@v3
  with:
  name: size-data
  run_id: ${{ github.event.workflow_run.id }}
  path: temp/size
 
  - name: Download Previous Size Data
- uses: dawidd6/action-download-artifact@v2
+ uses: dawidd6/action-download-artifact@v3
  with:
  branch: main
  workflow: size-data.yml

CHANGELOG.md

@@ -1,3 +1,69 @@
+## [3.4.19](https://github.com/vuejs/core/compare/v3.4.18...v3.4.19) (2024-02-13)
+
+
+### Bug Fixes
+
+* **deps:** pin lru-cache to avoid hashing error ([b8be990](https://github.com/vuejs/core/commit/b8be99018ceae92d1732dfb414df12b36b90b31f)), closes [#10300](https://github.com/vuejs/core/issues/10300)
+* **hydration:** fix css vars hydration mismatch false positive on non-root nodes ([995d2fd](https://github.com/vuejs/core/commit/995d2fdcca485c24849c99f498c1edc163722e04)), closes [#10317](https://github.com/vuejs/core/issues/10317) [#10325](https://github.com/vuejs/core/issues/10325)
+* **runtime-dom:** should not trigger transition when v-show value is falsy ([#10311](https://github.com/vuejs/core/issues/10311)) ([e509639](https://github.com/vuejs/core/commit/e50963903d93a7f24003b6e2c03647fdf7454b1e))
+
+
+### Features
+
+> Note: this warning is categorized as a feature but released in a patch because it does not affect public APIs.
+
+* **dx:** warn users when computed is self-triggering ([#10299](https://github.com/vuejs/core/issues/10299)) ([f7ba97f](https://github.com/vuejs/core/commit/f7ba97f9754a9882c1f6b1c07ca1a4040479dd13))
+
+
+### Performance Improvements
+
+* **runtime:** improve `getType()` GC and speed ([#10327](https://github.com/vuejs/core/issues/10327)) ([603a1e1](https://github.com/vuejs/core/commit/603a1e1f5ad587c077f0d974c1bbe856be22ebe9))
+
+
+
+## [3.4.18](https://github.com/vuejs/core/compare/v3.4.17...v3.4.18) (2024-02-09)
+
+
+### Bug Fixes
+
+* **dx:** warn against reserved keys as prop name ([77a804b](https://github.com/vuejs/core/commit/77a804b1d0d6a3f12fb3674cdceb85ebd6481e02)), closes [#10281](https://github.com/vuejs/core/issues/10281)
+* **runtime-dom:** ensure v-show respects display value set via v-bind ([#10297](https://github.com/vuejs/core/issues/10297)) ([c224897](https://github.com/vuejs/core/commit/c224897dd4e189a10ec601a97fe08cb638ebee19)), closes [#10151](https://github.com/vuejs/core/issues/10151)
+
+
+
+## [3.4.17](https://github.com/vuejs/core/compare/v3.4.16...v3.4.17) (2024-02-09)
+
+
+### Reverts
+
+* fix(runtime-dom): ensure v-show respects display value set via v-bind ([#10161](https://github.com/vuejs/core/issues/10161)) ([2cd5b05](https://github.com/vuejs/core/commit/2cd5b05c3bf171be5c0b473c084c01704a058ffa)), closes [#10294](https://github.com/vuejs/core/issues/10294) [#10151](https://github.com/vuejs/core/issues/10151)
+
+
+
+## [3.4.16](https://github.com/vuejs/core/compare/v3.4.15...v3.4.16) (2024-02-08)
+
+
+### Bug Fixes
+
+* **compiler-core:** handle same-name shorthand edge case for in-DOM templates ([cb87b62](https://github.com/vuejs/core/commit/cb87b6213d7b003fa7280712c285c7c9d9f291ca)), closes [#10280](https://github.com/vuejs/core/issues/10280)
+* **compiler-core:** support v-bind shorthand syntax for dynamic slot name ([#10218](https://github.com/vuejs/core/issues/10218)) ([91f058a](https://github.com/vuejs/core/commit/91f058a90cd603492649633d153b120977c4df6b)), closes [#10213](https://github.com/vuejs/core/issues/10213)
+* **deps:** update compiler ([#10269](https://github.com/vuejs/core/issues/10269)) ([336bb65](https://github.com/vuejs/core/commit/336bb65820243006efdf990e6ea3610696467508))
+* **hydration:** fix SFC style v-bind hydration mismatch warnings ([#10250](https://github.com/vuejs/core/issues/10250)) ([f0b5f7e](https://github.com/vuejs/core/commit/f0b5f7ed8ddf74f9f5ba47cb65e8300370875291)), closes [#10215](https://github.com/vuejs/core/issues/10215)
+* **reactivity:** avoid infinite recursion from side effects in computed getter ([#10232](https://github.com/vuejs/core/issues/10232)) ([0bced13](https://github.com/vuejs/core/commit/0bced13ee5c53a02d5f10e5db76fe38b6e131440)), closes [#10214](https://github.com/vuejs/core/issues/10214)
+* **reactivity:** handle `MaybeDirty` recurse ([#10187](https://github.com/vuejs/core/issues/10187)) ([6c7e0bd](https://github.com/vuejs/core/commit/6c7e0bd88f021b0b6365370e97b0c7e243d7d70b)), closes [#10185](https://github.com/vuejs/core/issues/10185)
+* **reactivity:** skip non-extensible objects when using `markRaw` ([#10289](https://github.com/vuejs/core/issues/10289)) ([2312184](https://github.com/vuejs/core/commit/2312184bc335e0d32aa4c0c0b49190b6334849b4)), closes [#10288](https://github.com/vuejs/core/issues/10288)
+* **runtime-core:** avoid inlining isShallow ([#10238](https://github.com/vuejs/core/issues/10238)) ([53eee72](https://github.com/vuejs/core/commit/53eee72c3a96420db35236b5e8e4d9308a56e1b4))
+* **runtime-core:** support for nested calls to runWithContext ([#10261](https://github.com/vuejs/core/issues/10261)) ([75e02b5](https://github.com/vuejs/core/commit/75e02b5099a08166bdf407127916734c48209ee9)), closes [#10260](https://github.com/vuejs/core/issues/10260)
+* **runtime-dom:** ensure v-show respects display value set via v-bind ([#10161](https://github.com/vuejs/core/issues/10161)) ([9b19f09](https://github.com/vuejs/core/commit/9b19f0912104bfccb10c8cf5beab02b21a648935)), closes [#10151](https://github.com/vuejs/core/issues/10151)
+* **runtime-dom:** fix option selected update failed ([#10200](https://github.com/vuejs/core/issues/10200)) ([f31d782](https://github.com/vuejs/core/commit/f31d782e4668050a188ac0f11ba8d5b861b913ca)), closes [#10194](https://github.com/vuejs/core/issues/10194) [#10267](https://github.com/vuejs/core/issues/10267)
+
+
+### Reverts
+
+* perf(templateRef): avoid double render when using template ref on v-for ([eb1b911](https://github.com/vuejs/core/commit/eb1b9116d7cd4a5747e8dadcdc5ba921df011f64)), closes [#9908](https://github.com/vuejs/core/issues/9908) [#10210](https://github.com/vuejs/core/issues/10210) [#10234](https://github.com/vuejs/core/issues/10234)
+
+
+
 ## [3.4.15](https://github.com/vuejs/core/compare/v3.4.14...v3.4.15) (2024-01-18)
 
 

package.json

@@ -1,6 +1,6 @@
 {
  "private": true,
- "version": "3.4.15",
+ "version": "3.4.19",
  "packageManager": "pnpm@8.15.1",
  "type": "module",
  "scripts": {
@@ -93,7 +93,7 @@
  "markdown-table": "^3.0.3",
  "marked": "^11.2.0",
  "minimist": "^1.2.8",
- "npm-run-all2": "^5.0.2",
+ "npm-run-all2": "^6.1.2",
  "picocolors": "^1.0.0",
  "prettier": "^3.2.2",
  "pretty-bytes": "^6.1.1",

packages/compiler-core/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@vue/compiler-core",
- "version": "3.4.15",
+ "version": "3.4.19",
  "description": "@vue/compiler-core",
  "main": "index.js",
  "module": "dist/compiler-core.esm-bundler.js",

packages/compiler-core/src/errors.ts

@@ -78,7 +78,6 @@ export enum ErrorCodes {
  X_V_FOR_MALFORMED_EXPRESSION,
  X_V_FOR_TEMPLATE_KEY_PLACEMENT,
  X_V_BIND_NO_EXPRESSION,
- X_V_BIND_INVALID_SAME_NAME_ARGUMENT,
  X_V_ON_NO_EXPRESSION,
  X_V_SLOT_UNEXPECTED_DIRECTIVE_ON_SLOT_OUTLET,
  X_V_SLOT_MIXED_SLOT_USAGE,
@@ -99,6 +98,10 @@ export enum ErrorCodes {
  X_SCOPE_ID_NOT_SUPPORTED,
  X_VNODE_HOOKS,
 
+ // placed here to preserve order for the current minor
+ // TODO adjust order in 3.5
+ X_V_BIND_INVALID_SAME_NAME_ARGUMENT,
+
  // Special value for higher-order compilers to pick up the last code
  // to avoid collision of error codes. This should always be kept as the last
  // item.

packages/compiler-dom/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@vue/compiler-dom",
- "version": "3.4.15",
+ "version": "3.4.19",
  "description": "@vue/compiler-dom",
  "main": "index.js",
  "module": "dist/compiler-dom.esm-bundler.js",

packages/compiler-sfc/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@vue/compiler-sfc",
- "version": "3.4.15",
+ "version": "3.4.19",
  "description": "@vue/compiler-sfc",
  "main": "dist/compiler-sfc.cjs.js",
  "module": "dist/compiler-sfc.esm-browser.js",
@@ -54,9 +54,9 @@
  },
  "devDependencies": {
  "@babel/types": "^7.23.9",
- "@vue/consolidate": "^0.17.3",
+ "@vue/consolidate": "^1.0.0",
  "hash-sum": "^2.0.0",
- "lru-cache": "^10.2.0",
+ "lru-cache": "10.1.0",
  "merge-source-map": "^1.1.0",
  "minimatch": "^9.0.3",
  "postcss-modules": "^6.0.0",

packages/compiler-ssr/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@vue/compiler-ssr",
- "version": "3.4.15",
+ "version": "3.4.19",
  "description": "@vue/compiler-ssr",
  "main": "dist/compiler-ssr.cjs.js",
  "types": "dist/compiler-ssr.d.ts",

packages/reactivity/__tests__/computed.spec.ts

@@ -14,6 +14,7 @@ import {
  toRaw,
 } from '../src'
 import { DirtyLevels } from '../src/constants'
+import { COMPUTED_SIDE_EFFECT_WARN } from '../src/computed'
 
 describe('reactivity/computed', () => {
  it('should return updated value', () => {
@@ -467,6 +468,7 @@ describe('reactivity/computed', () => {
  expect(c3.effect._dirtyLevel).toBe(
  DirtyLevels.MaybeDirty_ComputedSideEffect,
  )
+ expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
  })
 
  it('should work when chained(ref+computed)', () => {
@@ -481,6 +483,7 @@ describe('reactivity/computed', () => {
  expect(c2.value).toBe('0foo')
  expect(c2.effect._dirtyLevel).toBe(DirtyLevels.Dirty)
  expect(c2.value).toBe('1foo')
+ expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
  })
 
  it('should trigger effect even computed already dirty', () => {
@@ -503,6 +506,7 @@ describe('reactivity/computed', () => {
  expect(c2.effect._dirtyLevel).toBe(DirtyLevels.Dirty)
  v.value = 2
  expect(fnSpy).toBeCalledTimes(2)
+ expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
  })
 
  // #10185
@@ -546,6 +550,7 @@ describe('reactivity/computed', () => {
  expect(c3.effect._dirtyLevel).toBe(DirtyLevels.MaybeDirty)
 
  expect(c3.value).toBe('yes')
+ expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
  })
 
  it('should be not dirty after deps mutate (mutate deps in computed)', async () => {
@@ -567,6 +572,7 @@ describe('reactivity/computed', () => {
  await nextTick()
  await nextTick()
  expect(serializeInner(root)).toBe(`2`)
+ expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
  })
 
  it('should not trigger effect scheduler by recurse computed effect', async () => {
@@ -589,5 +595,6 @@ describe('reactivity/computed', () => {
  v.value += ' World'
  await nextTick()
  expect(serializeInner(root)).toBe('Hello World World World World')
+ expect(COMPUTED_SIDE_EFFECT_WARN).toHaveBeenWarned()
  })
 })

packages/reactivity/__tests__/reactive.spec.ts

@@ -277,6 +277,11 @@ describe('reactivity/reactive', () => {
  expect(isReactive(obj.bar)).toBe(false)
  })
 
+ test('markRaw should skip non-extensible objects', () => {
+ const obj = Object.seal({ foo: 1 })
+ expect(() => markRaw(obj)).not.toThrowError()
+ })
+
  test('should not observe non-extensible objects', () => {
  const obj = reactive({
  foo: Object.preventExtensions({ a: 1 }),

packages/reactivity/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@vue/reactivity",
- "version": "3.4.15",
+ "version": "3.4.19",
  "description": "@vue/reactivity",
  "main": "index.js",
  "module": "dist/reactivity.esm-bundler.js",

packages/reactivity/src/computed.ts

@@ -4,6 +4,7 @@ import { NOOP, hasChanged, isFunction } from '@vue/shared'
 import { toRaw } from './reactive'
 import type { Dep } from './dep'
 import { DirtyLevels, ReactiveFlags } from './constants'
+import { warn } from './warning'
 
 declare const ComputedRefSymbol: unique symbol
 
@@ -24,6 +25,12 @@ export interface WritableComputedOptions<T> {
  set: ComputedSetter<T>
 }
 
+export const COMPUTED_SIDE_EFFECT_WARN =
+ `Computed is still dirty after getter evaluation,` +
+ ` likely because a computed is mutating its own dependency in its getter.` +
+ ` State mutations in computed getters should be avoided. ` +
+ ` Check the docs for more details: https://vuejs.org/guide/essentials/computed.html#getters-should-be-side-effect-free`
+
 export class ComputedRefImpl<T> {
  public dep?: Dep = undefined
 
@@ -67,6 +74,7 @@ export class ComputedRefImpl<T> {
  }
  trackRefValue(self)
  if (self.effect._dirtyLevel >= DirtyLevels.MaybeDirty_ComputedSideEffect) {
+ __DEV__ && warn(COMPUTED_SIDE_EFFECT_WARN)
  triggerRefValue(self, DirtyLevels.MaybeDirty_ComputedSideEffect)
  }
  return self._value
@@ -141,7 +149,7 @@ export function computed<T>(
  getter = getterOrOptions
  setter = __DEV__
  ? () => {
- console.warn('Write operation failed: computed value is readonly')
+ warn('Write operation failed: computed value is readonly')
  }
  : NOOP
  } else {

packages/reactivity/src/reactive.ts

@@ -385,7 +385,9 @@ export type Raw<T> = T & { [RawSymbol]?: true }
  * @see {@link https://vuejs.org/api/reactivity-advanced.html#markraw}
  */
 export function markRaw<T extends object>(value: T): Raw<T> {
- def(value, ReactiveFlags.SKIP, true)
+ if (Object.isExtensible(value)) {
+ def(value, ReactiveFlags.SKIP, true)
+ }
  return value
 }
 

packages/runtime-core/__tests__/componentProps.spec.ts

@@ -729,4 +729,23 @@ describe('component props', () => {
 
  expect(Object.keys(props.msg).length).toBe(1)
  })
+
+ test('should warn against reserved prop names', () => {
+ const Comp = defineComponent({
+ props: {
+ key: String,
+ ref: String,
+ $foo: String,
+ },
+ render() {},
+ })
+
+ const root = nodeOps.createElement('div')
+
+ render(h(Comp, { msg: 'test' }), root)
+
+ expect(`Invalid prop name: "key"`).toHaveBeenWarned()
+ expect(`Invalid prop name: "ref"`).toHaveBeenWarned()
+ expect(`Invalid prop name: "$foo"`).toHaveBeenWarned()
+ })
 })

packages/runtime-core/__tests__/hydration.spec.ts

@@ -1554,5 +1554,22 @@ describe('SSR hydration', () => {
  app.mount(container)
  expect(`Hydration style mismatch`).not.toHaveBeenWarned()
  })
+
+ // #10317 - test case from #10325
+ test('css vars should only be added to expected on component root dom', () => {
+ const container = document.createElement('div')
+ container.innerHTML = `<div style="--foo:red;"><div style="color:var(--foo);" /></div>`
+ const app = createSSRApp({
+ setup() {
+ useCssVars(() => ({
+ foo: 'red',
+ }))
+ return () =>
+ h('div', null, [h('div', { style: { color: 'var(--foo)' } })])
+ },
+ })
+ app.mount(container)
+ expect(`Hydration style mismatch`).not.toHaveBeenWarned()
+ })
  })
 })

packages/runtime-core/package.json

@@ -1,6 +1,6 @@
 {
  "name": "@vue/runtime-core",
- "version": "3.4.15",
+ "version": "3.4.19",
  "description": "@vue/runtime-core",
  "main": "index.js",
  "module": "dist/runtime-core.esm-bundler.js",