-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
572 changed files
with
33,977 additions
and
28,742 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
node_modules | ||
dist | ||
temp | ||
coverage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,84 +1,130 @@ | ||
const { builtinModules } = require('node:module') | ||
const DOMGlobals = ['window', 'document'] | ||
const NodeGlobals = ['module', 'require'] | ||
|
||
const banConstEnum = { | ||
selector: 'TSEnumDeclaration[const=true]', | ||
message: | ||
'Please use non-const enums. This project automatically inlines enums.', | ||
} | ||
|
||
/** | ||
* @type {import('eslint-define-config').ESLintConfig} | ||
*/ | ||
module.exports = { | ||
parser: '@typescript-eslint/parser', | ||
parserOptions: { | ||
sourceType: 'module' | ||
sourceType: 'module', | ||
}, | ||
plugins: ['jest'], | ||
plugins: ['jest', 'import', '@typescript-eslint'], | ||
rules: { | ||
'no-debugger': 'error', | ||
'no-unused-vars': [ | ||
'error', | ||
// we are only using this rule to check for unused arguments since TS | ||
// catches unused variables but not args. | ||
{ varsIgnorePattern: '.*', args: 'none' } | ||
], | ||
'no-console': ['error', { allow: ['warn', 'error', 'info'] }], | ||
// most of the codebase are expected to be env agnostic | ||
'no-restricted-globals': ['error', ...DOMGlobals, ...NodeGlobals], | ||
|
||
'no-restricted-syntax': [ | ||
'error', | ||
banConstEnum, | ||
// since we target ES2015 for baseline support, we need to forbid object | ||
// rest spread usage in destructure as it compiles into a verbose helper. | ||
'ObjectPattern > RestElement', | ||
// tsc compiles assignment spread into Object.assign() calls, but esbuild | ||
// still generates verbose helpers, so spread assignment is also prohiboted | ||
'ObjectExpression > SpreadElement', | ||
'AwaitExpression' | ||
] | ||
'AwaitExpression', | ||
], | ||
'sort-imports': ['error', { ignoreDeclarationSort: true }], | ||
|
||
'import/no-nodejs-modules': [ | ||
'error', | ||
{ allow: builtinModules.map(mod => `node:${mod}`) }, | ||
], | ||
// This rule enforces the preference for using '@ts-expect-error' comments in TypeScript | ||
// code to indicate intentional type errors, improving code clarity and maintainability. | ||
'@typescript-eslint/prefer-ts-expect-error': 'error', | ||
// Enforce the use of 'import type' for importing types | ||
'@typescript-eslint/consistent-type-imports': [ | ||
'error', | ||
{ | ||
fixStyle: 'inline-type-imports', | ||
disallowTypeAnnotations: false, | ||
}, | ||
], | ||
// Enforce the use of top-level import type qualifier when an import only has specifiers with inline type qualifiers | ||
'@typescript-eslint/no-import-type-side-effects': 'error', | ||
}, | ||
overrides: [ | ||
// tests, no restrictions (runs in Node / jest with jsdom) | ||
{ | ||
files: ['**/__tests__/**', 'packages/dts-test/**'], | ||
rules: { | ||
'no-console': 'off', | ||
'no-restricted-globals': 'off', | ||
'no-restricted-syntax': 'off', | ||
'jest/no-disabled-tests': 'error', | ||
'jest/no-focused-tests': 'error' | ||
} | ||
'jest/no-focused-tests': 'error', | ||
}, | ||
}, | ||
// shared, may be used in any env | ||
{ | ||
files: ['packages/shared/**'], | ||
files: ['packages/shared/**', '.eslintrc.cjs'], | ||
rules: { | ||
'no-restricted-globals': 'off' | ||
} | ||
'no-restricted-globals': 'off', | ||
}, | ||
}, | ||
// Packages targeting DOM | ||
{ | ||
files: ['packages/{vue,vue-compat,runtime-dom}/**'], | ||
rules: { | ||
'no-restricted-globals': ['error', ...NodeGlobals] | ||
} | ||
'no-restricted-globals': ['error', ...NodeGlobals], | ||
}, | ||
}, | ||
// Packages targeting Node | ||
{ | ||
files: [ | ||
'packages/{compiler-sfc,compiler-ssr,server-renderer,reactivity-transform}/**' | ||
], | ||
files: ['packages/{compiler-sfc,compiler-ssr,server-renderer}/**'], | ||
rules: { | ||
'no-restricted-globals': ['error', ...DOMGlobals], | ||
'no-restricted-syntax': 'off' | ||
} | ||
'no-restricted-syntax': ['error', banConstEnum], | ||
}, | ||
}, | ||
// Private package, browser only + no syntax restrictions | ||
{ | ||
files: ['packages/template-explorer/**', 'packages/sfc-playground/**'], | ||
rules: { | ||
'no-restricted-globals': ['error', ...NodeGlobals], | ||
'no-restricted-syntax': 'off' | ||
} | ||
'no-restricted-syntax': ['error', banConstEnum], | ||
'no-console': 'off', | ||
}, | ||
}, | ||
// JavaScript files | ||
{ | ||
files: ['*.js', '*.cjs'], | ||
rules: { | ||
// We only do `no-unused-vars` checks for js files, TS files are checked by TypeScript itself. | ||
'no-unused-vars': ['error', { vars: 'all', args: 'none' }], | ||
}, | ||
}, | ||
// Node scripts | ||
{ | ||
files: ['scripts/**', '*.{js,ts}', 'packages/**/index.js'], | ||
files: [ | ||
'scripts/**', | ||
'./*.{js,ts}', | ||
'packages/*/*.js', | ||
'packages/vue/*/*.js', | ||
], | ||
rules: { | ||
'no-restricted-globals': 'off', | ||
'no-restricted-syntax': 'off' | ||
} | ||
} | ||
] | ||
'no-restricted-syntax': ['error', banConstEnum], | ||
'no-console': 'off', | ||
}, | ||
}, | ||
// Import nodejs modules in compiler-sfc | ||
{ | ||
files: ['packages/compiler-sfc/src/**'], | ||
rules: { | ||
'import/no-nodejs-modules': ['error', { allow: builtinModules }], | ||
}, | ||
}, | ||
], | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# update prettier & eslint config (#9162) | ||
bfe6b459d3a0ce6168611ee1ac7e6e789709df9d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.