fix(compiler-sfc): asset url transform should ignore direct hash urls

vuejs · May 29, 2020 · 5ddd9d2 · 5ddd9d2
1 parent 8b9ee57
commit 5ddd9d2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/packages/compiler-sfc/__tests__/templateTransformAssetUrl.spec.ts b/packages/compiler-sfc/__tests__/templateTransformAssetUrl.spec.ts
@@ -79,4 +79,18 @@ describe('compiler sfc: transform asset url', () => {
  )
  expect(code).toMatchSnapshot()
  })
+
+ // vitejs/vite#298
+ test('should not transform hash fragments', () => {
+ const { code } = compileWithAssetUrls(
+ `<svg viewBox="0 0 10 10" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <defs>
+ <circle id="myCircle" cx="0" cy="0" r="5" />
+ </defs>
+ <use x="5" y="5" xlink:href="#myCircle" />
+ </svg>`
+ )
+ // should not remove it
+ expect(code).toMatch(`"xlink:href": "#myCircle"`)
+ })
 })
diff --git a/packages/compiler-sfc/src/templateTransformAssetUrl.ts b/packages/compiler-sfc/src/templateTransformAssetUrl.ts
@@ -99,6 +99,7 @@ export const transformAssetUrl: NodeTransform = (
  !assetAttrs.includes(attr.name) ||
  !attr.value ||
  isExternalUrl(attr.value.content) ||
+ attr.value.content[0] === '#' ||
  (!options.includeAbsolute && !isRelativeUrl(attr.value.content))
  ) {
  return