Apply suggestions from code review

Co-authored-by: 三咲智子 Kevin Deng <sxzz@sxzz.moe>
vuejs · Mar 6, 2023 · a4de664 · a4de664
1 parent f5014e2
commit a4de664
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/runtime-core/src/compat/global.ts b/packages/runtime-core/src/compat/global.ts
@@ -505,7 +505,7 @@ function installCompatMount(
 
  let namespace: 'svg' | 'mathml' | undefined
  if (container instanceof SVGElement) namespace = 'svg'
- if (container instanceof MathMLElement) namespace = 'mathml'
+ else if (container instanceof MathMLElement) namespace = 'mathml'
 
  // HMR root reload
  if (__DEV__) {

diff --git a/packages/runtime-dom/src/index.ts b/packages/runtime-dom/src/index.ts
@@ -102,7 +102,7 @@ export const createApp = ((...args) => {
  container.innerHTML = ''
  let namespace: 'svg' | 'mathml' | undefined
  if (container instanceof SVGElement) namespace = 'svg'
- if (container instanceof MathMLElement) namespace = 'mathml'
+ else if (container instanceof MathMLElement) namespace = 'mathml'
  const proxy = mount(container, false, namespace)
  if (container instanceof Element) {
  container.removeAttribute('v-cloak')
@@ -128,7 +128,7 @@ export const createSSRApp = ((...args) => {
  if (container) {
  let namespace: 'svg' | 'mathml' | undefined
  if (container instanceof SVGElement) namespace = 'svg'
- if (container instanceof MathMLElement) namespace = 'mathml'
+ else if (container instanceof MathMLElement) namespace = 'mathml'
  return mount(container, true, namespace)
  }
  }