Skip to content

Commit

Permalink
fix(ssr): fix hydration for node with empty text node (#7216)
Browse files Browse the repository at this point in the history
  • Loading branch information
edison1105 authored May 27, 2024
1 parent b487acd commit d1011c0
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
15 changes: 15 additions & 0 deletions packages/runtime-core/__tests__/hydration.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1160,6 +1160,21 @@ describe('SSR hydration', () => {
expect((vnode as any).component?.subTree.children[0].el).toBe(text)
})

// #7215
test('empty text node', () => {
const Comp = {
render(this: any) {
return h('p', [''])
}
}
const { container } = mountWithHydration('<p></p>', () => h(Comp))
expect(container.childNodes.length).toBe(1)
const p = container.childNodes[0]
expect(p.childNodes.length).toBe(1)
const text = p.childNodes[0]
expect(text.nodeType).toBe(3)
})

test('app.unmount()', async () => {
const container = document.createElement('DIV')
container.innerHTML = '<button></button>'
Expand Down
4 changes: 3 additions & 1 deletion packages/runtime-core/src/hydration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,9 @@ export function createHydrationFunctions(
optimized,
)
} else if (vnode.type === Text && !vnode.children) {
continue
// #7215 create a TextNode for empty text node
// because server rendered HTML won't contain a text node
insert((vnode.el = createText('')), container)
} else {
hasMismatch = true
if (
Expand Down

0 comments on commit d1011c0

Please sign in to comment.