Skip to content

Commit

Permalink
fix(runtime-core): ensure app instance can be gargabe collected after…
Browse files Browse the repository at this point in the history
… unmount

close #2907
  • Loading branch information
Thorsten Luenborg committed Dec 29, 2020
1 parent e5a5a2c commit d5d7c79
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/runtime-core/src/apiCreateApp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ export function createAppAPI<HostElement>(
if (__DEV__ || __FEATURE_PROD_DEVTOOLS__) {
devtoolsUnmountApp(app)
}
delete app._container.__vue_app__
} else if (__DEV__) {
warn(`Cannot unmount an app that is not mounted.`)
}
Expand Down

0 comments on commit d5d7c79

Please sign in to comment.