fix: patch form as an attribute

Close #1787
vuejs · Aug 5, 2020 · d6caddd · d6caddd
1 parent 2787c34
commit d6caddd
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/runtime-dom/__tests__/patchProps.spec.ts b/packages/runtime-dom/__tests__/patchProps.spec.ts
@@ -121,4 +121,12 @@ describe('runtime-dom: props patching', () => {
  patchProp(el, 'id', null, '')
  expect(el.hasAttribute('id')).toBe(true)
  })
+
+ test('form attribute', () => {
+ const el = document.createElement('input')
+ patchProp(el, 'form', null, 'foo')
+ // non existant element
+ expect(el.form).toBe(null)
+ expect(el.getAttribute('form')).toBe('foo')
+ })
 })
diff --git a/packages/runtime-dom/src/patchProp.ts b/packages/runtime-dom/src/patchProp.ts
@@ -93,6 +93,12 @@ function shouldSetAsProp(
  return false
  }
 
+ // #1787 form as an attribute must be a string, while it accepts an Element as
+ // a prop
+ if (key === 'form' && typeof value === 'string') {
+ return false
+ }
+
  // #1526 <input list> must be set as attribute
  if (key === 'list' && el.tagName === 'INPUT') {
  return false