Skip to content

Commit

Permalink
feat: improve static content stringiciation
Browse files Browse the repository at this point in the history
Now a single static vnode can contain stringified content
for multiple consecutive nodes, which greatly improves the
coverage of this optimization.
  • Loading branch information
yyx990803 committed May 17, 2020
1 parent 59d50da commit d965bb6
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 4 deletions.
5 changes: 4 additions & 1 deletion packages/compiler-core/src/transforms/hoistStatic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ function walk(
resultCache: Map<TemplateChildNode, boolean>,
doNotHoistNode: boolean = false
) {
let hasHoistedNode = false
for (let i = 0; i < children.length; i++) {
const child = children[i]
// only plain elements & text calls are eligible for hoisting.
Expand All @@ -55,6 +56,7 @@ function walk(
;(child.codegenNode as VNodeCall).patchFlag =
PatchFlags.HOISTED + (__DEV__ ? ` /* HOISTED */` : ``)
child.codegenNode = context.hoist(child.codegenNode!)
hasHoistedNode = true
continue
} else {
// node may contain dynamic children, but its props may be eligible for
Expand All @@ -81,6 +83,7 @@ function walk(
isStaticNode(child.content, resultCache)
) {
child.codegenNode = context.hoist(child.codegenNode)
hasHoistedNode = true
}

// walk further
Expand All @@ -98,7 +101,7 @@ function walk(
}
}

if (context.transformHoist) {
if (hasHoistedNode && context.transformHoist) {
context.transformHoist(children, context)
}
}
Expand Down
26 changes: 23 additions & 3 deletions packages/compiler-dom/src/transforms/stringifyStatic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,29 @@ export const enum StringifyThresholds {

type StringiableNode = PlainElementNode | TextCallNode

// Turn eligible hoisted static trees into stringied static nodes, e.g.
// const _hoisted_1 = createStaticVNode(`<div class="foo">bar</div>`)
// This is only performed in non-in-browser compilations.
/**
* Turn eligible hoisted static trees into stringied static nodes, e.g.
*
* ```js
* const _hoisted_1 = createStaticVNode(`<div class="foo">bar</div>`)
* ```
*
* A single static vnode can contain stringified content for **multiple**
* consecutive nodes (element and plain text), called a "chunk".
* `@vue/runtime-dom` will create the content via innerHTML in a hidden
* container element and insert all the nodes in place. The call must also
* provide the number of nodes contained in the chunk so that during hydration
* we can know how many nodes the static vnode should adopt.
*
* The optimization scans a children list that contains hoisted nodes, and
* tries to find the largest chunk of consecutive hoisted nodes before running
* into a non-hoisted node or the end of the list. A chunk is then converted
* into a single static vnode and replaces the hoisted expression of the first
* node in the chunk. Other nodes in the chunk are considered "merged" and
* therefore removed from both the hoist list and the children array.
*
* This optimization is only performed in Node.js.
*/
export const stringifyStatic: HoistTransform = (children, context) => {
let nc = 0 // current node count
let ec = 0 // current element with binding count
Expand Down

0 comments on commit d965bb6

Please sign in to comment.