fix(runtime-dom): attribute should be removed with nullish values (#2679

) fix #2677
vuejs · Dec 1, 2020 · fb6b9f8 · fb6b9f8
1 parent 64d4681
commit fb6b9f8
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/packages/runtime-dom/__tests__/patchProps.spec.ts b/packages/runtime-dom/__tests__/patchProps.spec.ts
@@ -120,6 +120,23 @@ describe('runtime-dom: props patching', () => {
 
     patchProp(el, 'id', null, '')
     expect(el.hasAttribute('id')).toBe(true)
+
+    // #2677
+    const img = document.createElement('img')
+    patchProp(img, 'width', null, '')
+    expect(el.hasAttribute('width')).toBe(false)
+    patchProp(img, 'width', null, 0)
+    expect(img.hasAttribute('width')).toBe(true)
+
+    patchProp(img, 'width', null, null)
+    expect(img.hasAttribute('width')).toBe(false)
+    patchProp(img, 'width', null, 0)
+    expect(img.hasAttribute('width')).toBe(true)
+
+    patchProp(img, 'width', null, undefined)
+    expect(img.hasAttribute('width')).toBe(false)
+    patchProp(img, 'width', null, 0)
+    expect(img.hasAttribute('width')).toBe(true)
   })
 
   test('form attribute', () => {

diff --git a/packages/runtime-dom/src/modules/props.ts b/packages/runtime-dom/src/modules/props.ts
@@ -41,6 +41,10 @@ export function patchDOMProp(
     // e.g. <div :id="null">
     el[key] = ''
     el.removeAttribute(key)
+  } else if ((value == null || value === '') && typeof el[key] === 'number') {
+    // e.g. <img :width="null">
+    el[key] = 0
+    el.removeAttribute(key)
   } else {
     // some properties perform value validation and throw
     try {