Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Web Elements/Components receive null instead of false on subsequent re-render #10324

Closed
Maxim-Mazurok opened this issue Feb 12, 2024 · 2 comments
Closed

Custom Web Elements/Components receive null instead of false on subsequent re-render #10324

Maxim-Mazurok opened this issue Feb 12, 2024 · 2 comments

Comments

@Maxim-Mazurok
Copy link

Maxim-Mazurok commented Feb 12, 2024 •
edited
Loading

Vue version

3.4.18

Link to minimal reproduction

https://jsfiddle.net/uwegz5y8/23/

Steps to reproduce

  1. Load repro
  2. See Boo: false; typeof: boolean - as expected, because boo attribute is not set
  3. Click "Toggle Boo"
  4. See Boo: true; typeof: boolean - as expected, because now boo attribute is set
  5. Click "Toggle Boo" again
  6. See Boo: null; typeof: object - unexpected, since boo attribute is removed - we expect to receive false just like in the 2nd step previously

What is expected?

false

What is actually happening?

null

System Info

No response

Any additional comments?

Kinda related: #9697
@edison1105
Copy link
Member

duplicated of #9006

@Maxim-Mazurok
Copy link
Author

duplicated of #9006

I'm not sure about that, on the surface it seems to be a different use-case since I don't use the default value, I can even make my prop to be required.

However, it is related, so I imagine that the same fix could resolve both issues at the same time.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
lynxlangya pushed a commit to lynxlangya/core that referenced this issue May 30, 2024
@edison1105 @lynxlangya
fix(custom-element): avoid setting attr to null if it is removed (vue…
550923b 
…js#9012)

Partially fixes vuejs#9006
Fixes vuejs#10324
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edison1105 @Maxim-Mazurok