Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler parse does not generate correct loc if end tag has whitepaces after the name #10694

Closed
pikax opened this issue Apr 14, 2024 · 0 comments
Closed

Compiler parse does not generate correct loc if end tag has whitepaces after the name #10694

pikax opened this issue Apr 14, 2024 · 0 comments
Assignees
@pikax
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has PR A pull request has already been submitted to solve the issue scope: compiler

Comments

@pikax
Copy link
Member

pikax commented Apr 14, 2024

Vue version

3.4.21

Link to minimal reproduction

https://template-explorer.vuejs.org/#eyJzcmMiOiI8c3Bhbj5zb21lIHRleHQ8L3NwYW5cblxuXG4+Iiwib3B0aW9ucyI6eyJob2lzdFN0YXRpYyI6dHJ1ZSwiaW5saW5lIjp0cnVlLCJvcHRpbWl6ZUltcG9ydHMiOmZhbHNlfX0=

Steps to reproduce

Open the console and check AST

children[0].loc.source is <span>some text</span\n

What is expected?

to be

<span>some text</span


>

What is actually happening?

is ignoring past the whitespance

System Info

No response

Any additional comments?

No response
@pikax pikax added scope: compiler 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Apr 14, 2024
@pikax pikax self-assigned this Apr 14, 2024
@pikax pikax mentioned this issue Apr 14, 2024
Closed
@pikax pikax added the has PR A pull request has already been submitted to solve the issue label Apr 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
lynxlangya pushed a commit to lynxlangya/core that referenced this issue May 30, 2024
@yyx990803 @lynxlangya
fix(compiler-core): fix loc.source for end tags with whitespace before >
cf501b6 
close vuejs#10694
close vuejs#10695
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pikax pikax

Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has PR A pull request has already been submitted to solve the issue scope: compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-core): append full tagEnd in generated loc.source vuejs/core
1 participant
@pikax