-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsconfig project reference didn't support folder #10907
Labels
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
scope: sfc
Comments
cyrilluce
pushed a commit
to cyrilluce/vuejs-core
that referenced
this issue
May 11, 2024
haoqunjiang
added
scope: sfc
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
labels
May 11, 2024
yyx990803
pushed a commit
that referenced
this issue
Jun 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
scope: sfc
Vue version
3.4.27
Link to minimal reproduction
https://stackblitz.com/edit/vitejs-vite-akygzo?file=tsconfig.json
Steps to reproduce
Check the stackblitz, if tsconfig project reference to file is ok, but folder will fail
What is expected?
What is actually happening?
[plugin:vite:vue] [@vue/compiler-sfc] Failed to resolve import source "@/types".
System Info
No response
Any additional comments?
Actually there are two problems:
which
included
is undefined inresolveWithTS
Why there are non-exists reference?
My project is a monorepo, use pnpm workspace, has packages
a
,b
andc
, and there npm package name is@xx/xx-a
,@xx/xx-b
and@xx/xx-c
a
depsb
,b
depsc
tsconfig.json
project reference to get better ts dev experience (e.g.a/tsconfig.json
ref to../b/tsconfig.json
)packages/a/node_modules/@xx/xx-b
topackages/b
, same asb
toc
In this case,
tsconfig.json
innode_modules
will get wrong relative path,packages/a/node_modules/@xx/xx-b/tsconfig.json
ref to../b/tsconfig.json
, which should be../xx-b/tsconfig.json
Only make monorepo package dir name sync to package name could prevent this. (e.g. package
@xx/xx-a
should usexx-a
directory)The text was updated successfully, but these errors were encountered: