Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransitionGroup: error on next update after standalone child (not v-for) was removed #1104

Closed
jonaskuske opened this issue May 2, 2020 · 0 comments · Fixed by #1105
Closed

TransitionGroup: error on next update after standalone child (not v-for) was removed #1104

jonaskuske opened this issue May 2, 2020 · 0 comments · Fixed by #1105

Comments

@jonaskuske
Copy link
Contributor

Version

3.0.0-beta.6

Reproduction link

https://codepen.io/21stCenturyJonas/pen/LYpOEEK

Steps to reproduce

  1. Click Remove "Three"
  2. Click Shuffle
  3. Check console

What is expected?

The remaining items ("One" and "Two") are shuffled and rendered.

What is actually happening?

TypeError: child.el.getBoundingClientRect is not a function
    at Proxy.<anonymous> (vue.esm-browser.js:10946)
    at renderComponentRoot (vue.esm-browser.js:5010)
    at componentEffect (vue.esm-browser.js:7809)
    at reactiveEffect (vue.esm-browser.js:3977)
    at callWithErrorHandling (vue.esm-browser.js:4815)
    at flushJobs (vue.esm-browser.js:4957)

Removing items from a list that's rendered via v-for works as expected, the error happens only if the removed node was "standalone".
underfin added a commit to underfin/vue-next that referenced this issue May 3, 2020
@underfin
fix(transitionGroup): inner children should skip comment node
ded8bfb 
fix: vuejs#1104
@underfin underfin mentioned this issue May 3, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(transitionGroup): inner children should skip comment node underfin/vue-next
1 participant
@jonaskuske