Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transitionGroup): inner children should skip comment node #1105

Merged
merged 2 commits into from
May 4, 2020
Merged

fix(transitionGroup): inner children should skip comment node #1105

merged 2 commits into from
May 4, 2020

Conversation

underfin
Copy link
Member

@underfin underfin commented May 3, 2020

fix: #1104

@yyx990803 yyx990803 merged commit 26a50ce into vuejs:master May 4, 2020
@underfin underfin deleted the fix-transitongroup branch May 4, 2020 16:48
@danyadev
Copy link

danyadev commented May 4, 2020

After this “fix”, all uses of TransitionGroup with keyed v-for began to display warnings in the console

image
image

@yyx990803
Copy link
Member

@danyadev fixed in f05aeea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TransitionGroup: error on next update after standalone child (not v-for) was removed
3 participants
@underfin @danyadev @yyx990803