Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Comment between component root elements prevents applying class to element after comment #2780

Closed
AleksandrSl opened this issue Dec 9, 2020 · 2 comments · Fixed by #2785
Closed

HTML Comment between component root elements prevents applying class to element after comment #2780

AleksandrSl opened this issue Dec 9, 2020 · 2 comments · Fixed by #2785
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has workaround A workaround has been found to avoid the problem 🐞 bug Something isn't working

Comments

@AleksandrSl
Copy link

Version

3.0.4

Reproduction link

https://codesandbox.io/s/strange-poitras-4jwf8?file=/src/components/HelloWorld.vue

Steps to reproduce

Try to remove comment between divs in HelloWorld component and resulting html will differ. Text I also want to be bold? will become bold

What is expected?

Class should be passed to the root element in both cases (Second component text should also be bold)

What is actually happening?

Due to presence of comment between divs, class is not applied to the second div.
@posva posva added 🐞 bug Something isn't working 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has workaround A workaround has been found to avoid the problem labels Dec 9, 2020
@edison1105 edison1105 mentioned this issue Dec 10, 2020
Closed
@edison1105
Copy link
Member

v3.0.3 is works fine.caused by 3bc2914

@HcySunYang HcySunYang mentioned this issue Dec 10, 2020
Merged
@HcySunYang
Copy link
Member

Hi @edison1105 , sorry, I didn’t notice your PR, but I just checked it. I think we need to add the flags to fragment correctly instead of letting it pass directly.

yyx990803 pushed a commit that referenced this issue Mar 25, 2021
@HcySunYang
fix(compiler-core): detect v-if branch root with comment as dev fragm…
4bf7ba1 
…ent (#2785)

fix #2780
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has workaround A workaround has been found to avoid the problem 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@posva @edison1105 @HcySunYang @AleksandrSl